Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zcash_client_sqlite: Add Orchard wallet support #1182

Merged
merged 14 commits into from
Mar 12, 2024

Apply suggestions from code review

5a28970
Select commit
Loading
Failed to load commit list.
Merged

zcash_client_sqlite: Add Orchard wallet support #1182

Apply suggestions from code review
5a28970
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Mar 12, 2024 in 1s

60.90% of diff hit (target 63.38%)

View this Pull Request on Codecov

60.90% of diff hit (target 63.38%)

Annotations

Check warning on line 448 in zcash_client_backend/src/data_api/wallet/input_selection.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_backend/src/data_api/wallet/input_selection.rs#L448 

Added line #L448 was not covered by tests

Check warning on line 176 in zcash_client_backend/src/fees.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_backend/src/fees.rs#L175-L176 

Added lines #L175 - L176 were not covered by tests

Check warning on line 205 in zcash_client_backend/src/fees.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_backend/src/fees.rs#L204-L205 

Added lines #L204 - L205 were not covered by tests

Check warning on line 208 in zcash_client_backend/src/fees.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_backend/src/fees.rs#L208 

Added line #L208 was not covered by tests

Check warning on line 210 in zcash_client_backend/src/fees.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_backend/src/fees.rs#L210 

Added line #L210 was not covered by tests

Check warning on line 215 in zcash_client_backend/src/fees.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_backend/src/fees.rs#L214-L215 

Added lines #L214 - L215 were not covered by tests

Check warning on line 217 in zcash_client_backend/src/fees.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_backend/src/fees.rs#L217 

Added line #L217 was not covered by tests

Check warning on line 173 in zcash_client_backend/src/fees/common.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_backend/src/fees/common.rs#L173 

Added line #L173 was not covered by tests

Check warning on line 177 in zcash_client_backend/src/fees/common.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_backend/src/fees/common.rs#L177 

Added line #L177 was not covered by tests

Check warning on line 212 in zcash_client_sqlite/src/lib.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_sqlite/src/lib.rs#L212 

Added line #L212 was not covered by tests

Check warning on line 218 in zcash_client_sqlite/src/lib.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_sqlite/src/lib.rs#L214-L218 

Added lines #L214 - L218 were not covered by tests

Check warning on line 223 in zcash_client_sqlite/src/lib.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_sqlite/src/lib.rs#L222-L223 

Added lines #L222 - L223 were not covered by tests

Check warning on line 253 in zcash_client_sqlite/src/lib.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_sqlite/src/lib.rs#L247-L253 

Added lines #L247 - L253 were not covered by tests

Check warning on line 969 in zcash_client_sqlite/src/lib.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_sqlite/src/lib.rs#L964-L969 

Added lines #L964 - L969 were not covered by tests

Check warning on line 974 in zcash_client_sqlite/src/lib.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_sqlite/src/lib.rs#L973-L974 

Added lines #L973 - L974 were not covered by tests

Check warning on line 936 in zcash_client_sqlite/src/wallet.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_sqlite/src/wallet.rs#L932-L936 

Added lines #L932 - L936 were not covered by tests

Check warning on line 939 in zcash_client_sqlite/src/wallet.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_sqlite/src/wallet.rs#L939 

Added line #L939 was not covered by tests

Check warning on line 947 in zcash_client_sqlite/src/wallet.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_sqlite/src/wallet.rs#L942-L947 

Added lines #L942 - L947 were not covered by tests

Check warning on line 951 in zcash_client_sqlite/src/wallet.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_sqlite/src/wallet.rs#L950-L951 

Added lines #L950 - L951 were not covered by tests

Check warning on line 979 in zcash_client_sqlite/src/wallet.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_sqlite/src/wallet.rs#L979 

Added line #L979 was not covered by tests

Check warning on line 992 in zcash_client_sqlite/src/wallet.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_sqlite/src/wallet.rs#L984-L992 

Added lines #L984 - L992 were not covered by tests

Check warning on line 994 in zcash_client_sqlite/src/wallet.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_sqlite/src/wallet.rs#L994 

Added line #L994 was not covered by tests

Check warning on line 997 in zcash_client_sqlite/src/wallet.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_sqlite/src/wallet.rs#L997 

Added line #L997 was not covered by tests

Check warning on line 1025 in zcash_client_sqlite/src/wallet.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_sqlite/src/wallet.rs#L1023-L1025 

Added lines #L1023 - L1025 were not covered by tests

Check warning on line 1041 in zcash_client_sqlite/src/wallet.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_sqlite/src/wallet.rs#L1039-L1041 

Added lines #L1039 - L1041 were not covered by tests
View more details on Codecov