Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zcash_client_sqlite: Implement Orchard scanning #1255

Merged
merged 7 commits into from
Mar 11, 2024
Merged

zcash_client_sqlite: Implement Orchard scanning #1255

merged 7 commits into from
Mar 11, 2024

Conversation

str4d
Copy link
Contributor

@str4d str4d commented Mar 11, 2024 •
edited
Loading

Part of #1176.
Closes #1198.

@str4d str4d added this to the Librustzcash Zashi 1.0 milestone Mar 11, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 30.86420% with 112 lines in your changes are missing coverage. Please review.

Project coverage is 63.38%. Comparing base (0780272) to head (22ed9eb).

❗ Current head 22ed9eb differs from pull request most recent head 33be548. Consider uploading reports for the commit 33be548 to get more accurate results

Files Patch % Lines
zcash_client_sqlite/src/lib.rs 34.74% 77 Missing ⚠️
zcash_client_sqlite/src/wallet/orchard.rs 0.00% 21 Missing ⚠️
zcash_client_sqlite/src/wallet.rs 39.13% 14 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1255      +/-   ##
==========================================
- Coverage   63.82%   63.38%   -0.45%     
==========================================
  Files         119      120       +1     
  Lines       12999    13124     +125     
==========================================
+ Hits         8296     8318      +22     
- Misses       4703     4806     +103

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

daira
daira previously approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK (reviewed with @str4d).

daira
daira approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 33be548

@str4d str4d merged commit a9aabb2 into main Mar 11, 2024
21 of 24 checks passed
@str4d str4d deleted the orchard-scanning branch March 11, 2024 18:54
ebfull
ebfull approved these changes Mar 11, 2024
View reviewed changes
Copy link
Collaborator

@ebfull ebfull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, though I didn't look very closely to some of the SQL.

zcash_client_sqlite/src/lib.rs Show resolved Hide resolved
@str4d str4d mentioned this pull request Mar 11, 2024
Closed
@nuttycom nuttycom mentioned this pull request Mar 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebfull ebfull ebfull approved these changes

@daira daira daira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Librustzcash Zashi 1.0
Development

Successfully merging this pull request may close these issues.

zcash_client_sqlite: implement WalletRead::get_orchard_nullifiers
4 participants
@str4d @daira @ebfull @nuttycom