Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return partial matches when using WalletRead::get_account_for_ufvk. #1258

Merged
merged 3 commits into from
Mar 12, 2024
Merged

Return partial matches when using WalletRead::get_account_for_ufvk. #1258

merged 3 commits into from
Mar 12, 2024

Conversation

nuttycom
Copy link
Contributor

@nuttycom nuttycom commented Mar 12, 2024 •
edited
Loading

Also, return the backend database's view of the matching UFVK.

@nuttycom nuttycom mentioned this pull request Mar 12, 2024
Merged
@codecov Codecov
Copy link

codecov bot commented Mar 12, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 78.57143% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 63.40%. Comparing base (a9aabb2) to head (7cfaa42).

Files Patch % Lines
zcash_client_sqlite/src/wallet.rs 78.04% 9 Missing ⚠️
zcash_client_backend/src/data_api.rs 25.00% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1258      +/-   ##
==========================================
+ Coverage   63.38%   63.40%   +0.02%     
==========================================
  Files         120      120              
  Lines       13124    13170      +46     
==========================================
+ Hits         8318     8351      +33     
- Misses       4806     4819      +13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

str4d
str4d previously approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 09181f4 after error message is clarified.

zcash_client_sqlite/src/wallet.rs Outdated Show resolved Hide resolved
@str4d str4d added this to the Librustzcash Zashi 1.0 milestone Mar 12, 2024
str4d
str4d approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 7cfaa42

@str4d
Copy link
Contributor

str4d commented Mar 12, 2024

Waiting for #1182 to be merged before merging this.

@nuttycom nuttycom merged commit 5e810d3 into zcash:main Mar 12, 2024
22 of 25 checks passed
@nuttycom nuttycom deleted the sqlite_wallet/fuzzy_key_matching branch March 12, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@str4d str4d str4d approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Librustzcash Zashi 1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nuttycom @str4d