Skip to content

fix: correct SSH URL format for private repos #721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sienks
Copy link
Contributor

@sienks sienks commented Jun 4, 2025

Description

Fixed an issue with SSH protocol URL formatting for private repositories. The code now properly handles SSH URLs when cloning private repositories.

Related Issue(s)

Does not fix an open issue.

Motivation and Context

When trying to load some custom zsh plugins I created from a private repo, zinit was unable to clone from the private repo.

Usage examples

# Using SSH protocol with private repository (existing functionality now works)
zinit ice proto"ssh"
zinit load "username/private-repo"

How Has This Been Tested?

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • Documentation change
  • New feature (non-breaking change which adds functionality)

Checklist:

  • All new and existing tests passed.
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.

@sienks
Copy link
Contributor Author

sienks commented Jun 5, 2025

When I checked, the main branch already has some failing tests. My changes do not introduce any new test failures and shouldn't, as they only modify the URL format.

@pschmitt
Copy link
Member

pschmitt commented Jun 5, 2025

all good, this is going in. Thanks!

@pschmitt pschmitt merged commit 991e4a8 into zdharma-continuum:main Jun 5, 2025
15 of 19 checks passed
@sienks sienks deleted the fix/ssh-protocol-url-format branch June 5, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants