Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show git items in the panel only when in a git repository #24865

Merged
merged 9 commits into from
Feb 21, 2025

Conversation

Angelk90
Copy link
Contributor

@Angelk90 Angelk90 commented Feb 14, 2025

Before After After2
Screenshot 2025-02-14 alle 13 45 41 Screenshot 2025-02-14 alle 14 25 24 Screenshot 2025-02-14 alle 14 25 38

Release Notes:

  • If it is not a git repository it shows nothing.
  • Fix stage and unstage title in context_menu

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Feb 14, 2025
@Angelk90 Angelk90 changed the title Fix Show git items in the panel only if it is a git repository Feb 14, 2025
@maxdeviant maxdeviant changed the title Show git items in the panel only if it is a git repository Show git items in the panel only when in a git repository Feb 14, 2025
@ConradIrwin
Copy link
Member

Thanks!

Should we just not have the panel at all in this case?

@Angelk90
Copy link
Contributor Author

@ConradIrwin : I don't understand what you mean.

@nervenes
Copy link
Contributor

nervenes commented Feb 15, 2025

Should we just not have the panel at all in this case?

it would be nice to have a button for creating a git repo from the panel, rather than forcing cli usage. for example, vscode:

Screenshot 2025-02-15 at 10 02 46

@Angelk90
Copy link
Contributor Author

Angelk90 commented Feb 15, 2025

@nervenes : I think this is a great idea.

Webstorm:
Screenshot 2025-02-15 alle 10 24 33

Screenshot 2025-02-15 alle 10 27 36

AuroraEditor:
Screenshot 2025-02-15 alle 10 37 29
Screenshot 2025-02-15 alle 10 38 06

CodeEdit:
Screenshot 2025-02-15 alle 10 45 52

@Angelk90 Angelk90 reopened this Feb 19, 2025
@Angelk90
Copy link
Contributor Author

@ConradIrwin : What do we want to do?
Are there any changes to be made or not?

@Angelk90
Copy link
Contributor Author

What do you think of a text like this:
Screenshot 2025-02-19 alle 19 39 15

@ConradIrwin
Copy link
Member

@Angelk90 sorry for the slow response here; and thank you for this!

@ConradIrwin ConradIrwin merged commit 17323ed into zed-industries:main Feb 21, 2025
12 checks passed
@ConradIrwin
Copy link
Member

I want to descope a "create new git repo" button for now, as to do that well requires configuring origins etc.

@Angelk90 Angelk90 deleted the git-panel-no-git branch February 21, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants