Initial pass on reusing existing panes when splitting #25030
+176
−70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds an optional argument to `pane::Split*` actions called `use_existing`. This argument defaults to false. When it is true, Zed will try to split the active item of the current pane *into* an existing pane in the designated Split direction. Open questions/further work: * Implement this feature for terminal_panel * Consider implementing this feature for other actions? * Do folks like the argument name "use_existing"? Is it clear enough?
|
We require contributors to sign our Contributor License Agreement, and we don't have @carlsverre on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
@cla-bot check |
cla-bot
bot
added
the
cla-signed
|
The cla-bot has been summoned, and re-checked this pull request! |
|
Just saw that actions were run! Appreciate that. Although tests aren't working yet. Wanted to get some signal on my approach before finishing the PR up. |
…nsures the cursor position is the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an optional argument to
pane::Split*actions calleduse_existing. This argument defaults to false. When it is true, Zed will try to split the active item of the current pane into an existing pane in the designated Split direction.Open questions/further work:
editor::GoToXSplitactionsCloses #24889
Release Notes:
use_existingoptional argument topane::Split*actions, allowing existing panes to be reused