vim: Refactor and fix multiline operations

[5brian]

Changes:

Matches neovim:

• Cursor at the start during yank operations on objects (yip, yab etc).

From plugins:

• Text object operations in visual block and visual line modes maintains original visual mode after completion.
• Refactors this: Trim all leading and trailing whitespace from inner multiline bracket selection.
  • This leaves a nicely indented line when doing ci{ vi{d etc
  • Checks for empty selection
  • Removed moving cursor to the start in visual bracket operations

This cleans up the previous implementation by providing a simpler check in surrounding_markers, instead of calling a new function in expand_object. No functionality was changed there except for handling the empty selection and removing some cursor adjustments that should not have been there after further testing.

Release Notes:

• vim: Text object operations in visual block and visual line modes maintains original visual mode after completion.

[ConradIrwin]

Thank you! Blazingly fast as usual :D.

Could you please incorporate the original example from the issue as a test

[ConradIrwin]

I'm going to fix the crash for now: #25138, but sounds like we should make bigger changes here?

Happy to wait until you're done with exams

[5brian]

Sounds good, thanks! will continue working on these

When yanking inside brackets like yib, cursor should move to the front.
When in visual block, using text objects should stay in visual block after the operation.

[ConradIrwin]

@5brian when I do vi( in nvim --clean it acts like your vib screenshot - i.e. in this case it does select all the whitespace. Do you have other plugins that are changing this behavior?

[5brian]

Ah, just realized i had mini.nvim affecting the selections. Will redo this

[5brian]

@ConradIrwin should be good for a review now, updated the description with the changes

Just confused about a test case i added for having visual line persist after using objects.
Performing shift-v a { from inside a brace should result in the whole function including the declaration being selected, in visual line mode. I added the test with the set and assert exactly like that, when testing locally it works, but the ci test is failing -- i'm probably missing something but i cant think of anything

assert	local build	ci

[ConradIrwin]

The line mode selections are not reflected in the positions of the « »; even though the selection looks like it covers the whole line. If you hit v in that situation you can see where the real selection is, which should match what the test is assuming

[5brian]

Thank you

[ConradIrwin]

@5brian can we keep using the NeovimBackedtestcontext for either of these tests given the above? Ideally we are exactly matching neovim when it has the features we have

[5brian]

@ConradIrwin from my testing against nvim --clean

    cx.simulate_keystrokes("a ]");
    cx.assert_state("hello (in «[parens]ˇ» o)", Mode::VisualBlock);

Switches to visual mode instead of staying in visual block

    cx.simulate_keystrokes("shift-v a {");
    cx.assert_state(
        indoc! {
            "func empty(a string) bool «{
               if a == \"\" {
                  return true
               }
               return false
            }ˇ»"
        },

Switches to visual mode instead of staying in visual line

I have them both staying in their original mode after the object operations, let me know if this is something i should change