Remove old telemetry event variants and transformation layer

[JosephTLyons]

Now that all events have been migrated to use telemetry::event!, we can remove the old event variants. It looks like the last round of event migration code landed in stable in v0.173 (#24102). I don't plan to land this for a few weeks, to give users more time to migrate >= v0.173.

As a side note, I've renamed AssistantEvent to AssistantEventData, as it no longer represents an event itself, but simply data being bundled and injected into an event.

Once landed, we will need to deploy a new collab.

Release Notes:

• N/A

[JosephTLyons]

I'm assuming events in the old format will get rejected here?

[ConradIrwin]

@JosephTLyons the JSON format we send over the wire can't easily change as we have to update server/client in tandem.

It's totally fine to delete the old events if we don't want to process them anymore.

[JosephTLyons]

At some point, users will be upgraded to a version where all events are generated via event! and those events no longer interact with the code I deleted in collab, as it was only meant to handle the old historical event format. Do I need to roll back the change that flattens the FlexbileEvent out then? I only removed that as it would be the only variable left in the event enum, but if that changes the json format, I can see why we shouldn't do that.

[ConradIrwin]

I think so (unfortunately) as otherwise there'll be a hard cut-off date. If you could have collab continue parsing either format that would also work.

[JosephTLyons]

Ok, I rolled back to FlexibleEvent. The idea of having collab parse the wrapped Event and the event data flattened out is appealing, and then we could just remove the wrapped one later down the line, but not sure how to deal with that now. I think this should be good to land after a few more releases. Really just wanted that migration code out of collab.

[ConradIrwin]

Sounds good!

…

On Thu, Feb 20, 2025 at 8:00 PM, Joseph T. Lyons ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In crates/collab/src/api/events.rs <#25179 (comment)>: > - ), - Event::Action(e) => ( - "Action Invoked".to_string(), - serde_json::to_value(e).unwrap(), - ), - Event::Repl(e) => ( - "Kernel Status Changed".to_string(), - serde_json::to_value(e).unwrap(), - ), - Event::Flexible(e) => ( - e.event_type.clone(), - serde_json::to_value(&e.event_properties).unwrap(), - ), - }; - + let mut event_properties = serde_json::to_value(&event.event.event_properties).unwrap(); if let serde_json::Value::Object(ref mut map) = event_properties { Ok, I rolled back to FlexibleEvent. The idea of having collab parse the wrapped Event and the event data flattened out is appealing, and then we could just remove the wrapped one later down the line, but not sure how to deal with that now. I think this should be good to land after a few more releases. Really just wanted that migration code out of collab. — Reply to this email directly, view it on GitHub <#25179 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAXAQFJ5BL62US5JHXYXYT2Q2JDDAVCNFSM6AAAAABXOZNRR6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMMZRG42DENRRGM> . You are receiving this because you were mentioned.Message ID: ***@***.***>