Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add editor actions for moving and selecting to next / previous excerpt #25299

Merged

Conversation

mgsloan
Copy link
Contributor

@mgsloan mgsloan commented Feb 21, 2025

Covers part of #5129 by adding MoveToStartOfExcerpt, MoveToEndOfExcerpt, SelectToStartOfExcerpt, and SelectToEndOfExcerpt.

No default linux bindings yet as it's unclear what to use. Currently, ctrl-up / ctrl-down scroll up and down by one line (see #13269). Considering changing the meaning of those.

Mac:

  • Previously cmd-up and cmd-down were editor::MoveToBeginning and editor::MoveToEnd. In singleton editors these will behave the same as before. In multibuffers, they will now step through excerpts instead of jumping to the beginning / end of the multibuffer.

  • cmd-home and cmd-end, often typed as cmd-fn-left and cmd-fn-right are now editor::MoveToBeginning and editor::MoveToEnd. This is useful in multibuffers.

Release Notes:

  • Mac: In the default keymap, cmd-up now moves to the previous multibuffer excerpt start, and cmd-down moves to the next multibuffer excerpt end. For normal buffers these behave the same as before, moving to the beginning or end.

Covers part of #5129.  No default linux bindings for now as it's unclear what to use.  Currently, `ctrl-up` / `ctrl-down` scroll up and down by one line (see #13269).
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Feb 21, 2025
@mgsloan mgsloan enabled auto-merge (squash) February 21, 2025 00:09
@mgsloan mgsloan merged commit 30850fe into main Feb 21, 2025
12 checks passed
@mgsloan mgsloan deleted the add-editor-actions-for-moving-to-and-selecting-excerpt branch February 21, 2025 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant