Add syntax scopes to themes #25323
Merged
Add syntax scopes to themes #25323
+369
−94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
This was referenced Feb 21, 2025
|
Awesome, thanks for the contribution. Going to get this one running since the others rely on it :) Are you ready to merge this? |
|
Yes, ready to merge. Thanks! |
maxdeviant
added a commit
that referenced
this pull request
Feb 21, 2025
This reverts commit 2f416ae.
maxdeviant
added a commit
that referenced
this pull request
Feb 21, 2025
This reverts commit 2f416ae. We shouldn't have merged this yet, as it currently breaks syntax highlighting for some languages that haven't had their requisite changes merged yet. We also need to be aware of the impact this will have on downstream themes. @chbk We should bundle any changes to the themes with the specific language highlights that depend on those changes (and if there are multiple languages that need the same change then pick one language to come first and then stack the rest of the changes on top of that). Release Notes: - Community: This is a revert of #25323, so remove those notes from the release notes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes:
Supports:
Changes:
Adds highlighting rules for the following new scopes, using theme colors:
headingnamespaceselectorstrikethroughunitRenames scopes that are no longer used in
zed/crates/languages/srcorzed/extensionsto their new names:punctuation.list_marker->punctuation.markuplink_text->linklink_uri->link.url, as defined in the gitcommit grammartext.literal->raw