Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terminal: Update terminal reopening from global to per-workspace #25336

Merged
merged 3 commits into from
Feb 21, 2025

Conversation

0xtimsb
Copy link
Member

@0xtimsb 0xtimsb commented Feb 21, 2025

Closes #7145

Currently, terminal persistence is global, i.e. split configurations are restored across all workspaces.

This PR changes it to per-workspace, so configurations are restored only within the same workspace. Opening a new window will start with a fresh terminal.

terminal-workspace.mov

Release Notes:

  • Improved terminal reopening to be per workspace instead of global.

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Feb 21, 2025
@0xtimsb 0xtimsb changed the title terminalworkspace based terminal serialization terminal: Workspace based terminal serialization Feb 21, 2025
@0xtimsb 0xtimsb changed the title terminal: Workspace based terminal serialization terminal: Update terminal reopening from global to per-workspace Feb 21, 2025
Copy link
Contributor

@SomeoneToIgnore SomeoneToIgnore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thank you.
LGTM after we ensure that this works for ssh projects.

@0xtimsb 0xtimsb merged commit 3759e0b into main Feb 21, 2025
12 checks passed
@0xtimsb 0xtimsb deleted the workspace-based-terminal-serialization branch February 21, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remember terminal tabs per-project
2 participants