vim: Handle visual selection when jumping to mark #25360
Merged
+20
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the way selections are handled when jumping to marks in Vim mode so as to not reset these when vim is in visual mode.
Fix regression in mark's behaviour, where a mark with multiple anchors was not activating all anchors again when jumping to that mark in normal mode, as `Motion::Jump` was being used even if not in visual mode. This commit fixes the issue by only using jump motion if in visual mode, making sure that the behaviour stays the same as before.
cla-bot
bot
added
the
cla-signed
maxdeviant
changed the title
|
@ConradIrwin Opened this Pull Request after this message, thank you so much for the help! By the way, I've noticed that, for a mark with multiple anchors, with this small change: diff --git a/crates/vim/src/normal/mark.rs b/crates/vim/src/normal/mark.rs
index 7040d55afd..381fd87ecb 100644
--- a/crates/vim/src/normal/mark.rs
+++ b/crates/vim/src/normal/mark.rs
@@ -144,11 +144,9 @@ impl Vim {
}
}
- if !should_jump {
- editor.change_selections(Some(Autoscroll::fit()), window, cx, |s| {
- s.select_anchor_ranges(ranges)
- });
- }
+ editor.change_selections(Some(Autoscroll::fit()), window, cx, |s| {
+ s.select_anchor_ranges(ranges)
+ });
});
if should_jump && anchor.is_some() {We can get the visual selection to be applied between the first and last anchor. Here's a quick video, let me know if you think that makes more sense than just jumping to the last anchor and I'll update these changes: visual_mode_jump_multiple_anchors.movThanks! 🙇 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix how vim mode handles jumping to mark, when one of vim's visual modes is active, in order to behave just like neovim. Here's a quick video showing the updated behavior ↓
vim_visual_selection_marks.mov
Closes #18131
Release Notes: