git: Make permalinks aware of current diffs #41915
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #22546, we want git permalinks to be aware of the current changes within the buffer.
This change calculates how many lines have been added/deleted between the start and end of the selection and uses those values to offset the selection.
This is done within
Editor::get_permalink_to_lineso that it can be passed to any git_store.Example:
Where this selections permalink would previously return L3-L9, it now returns L2-L7.
Release Notes:
Closes #22546
This is my first PR into the zed repository so very happy for any feedback on how I've implemented this. Thanks!