Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes:
I was changed
Fillto useBackgroundsince PR #20812.But it's not inconvenient to retrieve the background color already set in the current style.
For example: I have use
StyleRefinementa lot in GPUI Component, I may define astylefor an element andimpl Styled for MyElementfor allows user to override the element default style.In this case, I often need to get the
bgof user sets to do something, e.g.: Adjust that color opacity to border use.So, I make a little change for
Fillto splitSolidandBackground.Solid: Mostly if we usebg(gpui::red())theSolidwill be used.Background: For gradient background case.And with
colormethod to get the color fromFill.