Skip to content

Conversation

@anirudh1713
Copy link

@anirudh1713 anirudh1713 commented Nov 5, 2025

Closes #32894

TODO

  • Confirm is something similar needs to be fixed for horizontal scroll as well

Release Notes:

  • Fixed an issue where autoscroll fit strategy was falling back to autoscroll newest when all selection can't fit on screen

anirudh1713 and others added 2 commits October 24, 2025 18:01
`AutoscrollStrategy:Newest`

if selections can't fit on screen, auto scroll doesn't do anything with
this implementation.
@MrSubidubi MrSubidubi self-assigned this Nov 5, 2025
@zed-industries-bot
Copy link

Warnings
⚠️
editor: to not scroll if all selections can't fit on screen
        ^

Write PR titles using sentence case.

Have feedback on this plugin? Let's hear it!

Generated by 🚫 dangerJS against c8898e2

@cla-bot
Copy link

cla-bot bot commented Nov 5, 2025

We require contributors to sign our Contributor License Agreement, and we don't have @anirudh1713 on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@anirudh1713 anirudh1713 changed the title editor: to not scroll if all selections can't fit on screen editor: To not scroll if all selections can't fit on screen Nov 5, 2025
@anirudh1713
Copy link
Author

@cla-bot check

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Nov 5, 2025
@cla-bot
Copy link

cla-bot bot commented Nov 5, 2025

The cla-bot has been summoned, and re-checked this pull request!

@anirudh1713
Copy link
Author

Context on the changes: #32894 (comment)

To add to this, I've update the existing test as it was contradictory. I'm not sure what the test was targeting so I think someone with more context can verify if its ok to modify this behavior.

Another approach that comes to mind is to have an explicit (optional) fallback strategy that consumer of enum can pass. e.g. with autoscroll fit, you may optionally pass autoscroll newest as a fallback 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Find All References auto-scrolls to the last occurrence when editing the initial one

3 participants