Skip to content

http_client: Fix Codex ACP install robustness by staging downloads #45428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
cppcoffee wants to merge 2 commits into
base: main
Choose a base branch
from
Open

http_client: Fix Codex ACP install robustness by staging downloads #45428

cppcoffee wants to merge 2 commits into from
+86 −10

Conversation

@cppcoffee
Copy link
Contributor

@cppcoffee cppcoffee commented Dec 20, 2025

Release Notes:

  • Improved Codex ACP install robustness by staging downloads

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Dec 20, 2025
@cppcoffee cppcoffee marked this pull request as draft December 20, 2025 05:58
@cppcoffee cppcoffee marked this pull request as ready for review December 20, 2025 13:54
@cppcoffee
Copy link
Contributor Author

cppcoffee commented Dec 20, 2025 •
edited
Loading

http_client/project: Make GitHub binary installs atomic via staging

  • Download/extract GitHub release assets into a temporary staging path next to the destination, then rename into place on success.
  • Clean up staging files/dirs on extraction or rename failure to avoid leaving partial installs behind.

@cppcoffee
style
4dd1f6d 
Signed-off-by: Xiaobo Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla-signed The user has signed the Contributor License Agreement community champion

Projects

Quality Week – December 2025
Status: Community PRs

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@cppcoffee