Improve link pattern parsing to trim punctuation wrappers #45457
+229
−204
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes # (none)
Summary
Improved the jump-to-definition reliability for file paths in prose strings (comments, markdown, etc.) by smarter stripping of surrounding punctuation.
This allows
cmd/ctrl-clickto work on file paths in contexts like:`path/to/file`[link](path/to/file)(see path/to/file)Check path/to/file.`cat path/to/file`Technical Details
link_pattern_file_candidatesinhover_links.rsto iteratively trim common leading and trailing punctuation characters.test_hover_filenamesto be DRY: it now uses a single base document string and targeted replacements, making it easier to add new prose test cases without duplication.Release Notes: