Skip to content

Conversation

@sourcefrog
Copy link
Contributor

@sourcefrog sourcefrog commented Dec 20, 2025

In the Zed tree, crates/eval_utils/LICENSE-GPL is a symlink to itself:

drwxrwxr-x   3 mbp mbp  4096 Dec 17 20:44 ./
drwxrwxr-x 209 mbp mbp 12288 Dec 17 20:44 ../
-rw-rw-r--   1 mbp mbp   286 Dec 17 20:44 Cargo.toml
lrwxrwxrwx   1 mbp mbp    11 Dec 17 20:44 LICENSE-GPL -> LICENSE-GPL
-rw-rw-r--   1 mbp mbp    45 Dec 17 20:44 README.md
drwxrwxr-x   2 mbp mbp  4096 Dec 17 20:44 src/

Zed currently treats that as an error reading the symlink, and as a result:

The test about recursive symlinks fails without the fix.

This doesn't completely fix #25181, because the worktree crate also emits entries that it can't canonicalize. I'm not quite sure how to fix that yet, but adding tests and fixing one layer feels like a step forward?

Release Notes:

  • N/A

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Dec 20, 2025
@sourcefrog sourcefrog marked this pull request as ready for review December 20, 2025 18:14
@maxdeviant maxdeviant changed the title RealFS::metadata shouldn't error on recursive/looped symlinks Make RealFs::metadata not error on recursive/looped symlinks Dec 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement community champion

Projects

Status: Community PRs

Development

Successfully merging this pull request may close these issues.

Broken symlinks not shown in file tree

1 participant