Add support for diff.plus, diff.minus theme selectors #45459
+114
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update diff/highlights.scm to use semantic @diff.plus and @diff.minus tokens - Add diff.plus, diff.minus, diff.delta tokens to fallback theme - Add diff syntax tokens to all official themes (One, Gruvbox, Ayu) This fixes the issue where diff files showed inverted colors (additions in purple/blue, deletions in green) by using proper semantic tokens instead of @string and @Keyword.
cla-bot
bot
added
the
cla-signed
github-project-automation
bot
moved this to Community PRs
in Quality Week – December 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes inverted diff colors by introducing proper semantic tokens @diff.plus and @diff.minus for diff syntax highlighting, replacing the previous use of generic @string and @keyword tokens.
- Updated diff syntax grammar to use semantic tokens
@diff.plusand@diff.minus - Added diff.plus and diff.minus theme selectors to fallback theme and all official themes
- Removed TODO comments that were tracking this improvement
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| crates/languages/src/diff/highlights.scm | Replaced @string with @diff.plus and @keyword with @diff.minus for addition/deletion highlighting, removed TODO comments |
| crates/theme/src/fallback_themes.rs | Added diff.plus (green) and diff.minus (red) tokens to the default dark theme |
| assets/themes/one/one.json | Added diff.plus and diff.minus theme selectors to both One Dark and One Light themes |
| assets/themes/gruvbox/gruvbox.json | Added diff.plus and diff.minus theme selectors to all six Gruvbox variants (dark, light, and their contrast variants) |
| assets/themes/ayu/ayu.json | Added diff.plus and diff.minus theme selectors to all three Ayu variants (dark, mirage, and light) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue where diff files showed inverted colors (additions in purple/blue, deletions in green) by using proper semantic tokens instead of @string and @Keyword.
Related discussion in #34057 (thought there might be second issue in that issue)
Release Notes:
Before:
After:
Before:
After:
Before:
After: