Skip to content

workspace: Avoid environment contamination when opening local settings from remote#51174

Open
cppcoffee wants to merge 1 commit intozed-industries:mainfrom
cppcoffee:workspace_remote_open_settings
Open

workspace: Avoid environment contamination when opening local settings from remote#51174
cppcoffee wants to merge 1 commit intozed-industries:mainfrom
cppcoffee:workspace_remote_open_settings

Conversation

@cppcoffee
Copy link
Contributor

@cppcoffee cppcoffee commented Mar 10, 2026

Release Notes:

  • Fixed settings file cannot be opened when accessing a remote directory

before:

2026-03-10.18.19.49.mov

after:

2026-03-10.18.21.25.mov

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Mar 10, 2026
@dinocosta dinocosta added area:settings Feedback for preferences, configuration, etc platform:remote Remote development, SSH and zed-remote-server labels Mar 10, 2026
Copy link
Member

@dinocosta dinocosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @cppcoffee 👋

I've assigned this to a team member I suspect is more familiar with how this works but, while testing, I noticed there's changes in both workspace::Workspace::with_local_workspace and workspace::Workspace::with_local_or_wsl_workspace. Seems like settings_ui::SettingsWindow::open_current_settings_file and zed::zed::open_settings_file both end up using workspace::Workspace::with_local_or_wsl_workspace .

Reverting the changes to workspace::Workspace::with_local_workspace doesn't seem to break anything in terms of being able to open the settings file while in a remote project, so might be worth taking another look 🙂

@cppcoffee cppcoffee force-pushed the workspace_remote_open_settings branch from dd86686 to f21b72e Compare March 12, 2026 12:42
@cppcoffee
Copy link
Contributor Author

Hi, @dinocosta , You are right, only modify the environment variable in the with_local_or_wsl_workspace function to None.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:settings Feedback for preferences, configuration, etc cla-signed The user has signed the Contributor License Agreement platform:remote Remote development, SSH and zed-remote-server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants