workspace: Avoid environment contamination when opening local settings from remote#51174
workspace: Avoid environment contamination when opening local settings from remote#51174cppcoffee wants to merge 1 commit intozed-industries:mainfrom
Conversation
dinocosta
left a comment
There was a problem hiding this comment.
Hey @cppcoffee 👋
I've assigned this to a team member I suspect is more familiar with how this works but, while testing, I noticed there's changes in both workspace::Workspace::with_local_workspace and workspace::Workspace::with_local_or_wsl_workspace. Seems like settings_ui::SettingsWindow::open_current_settings_file and zed::zed::open_settings_file both end up using workspace::Workspace::with_local_or_wsl_workspace .
Reverting the changes to workspace::Workspace::with_local_workspace doesn't seem to break anything in terms of being able to open the settings file while in a remote project, so might be worth taking another look 🙂
…s from remote Signed-off-by: Xiaobo Liu <[email protected]>
dd86686 to
f21b72e
Compare
|
Hi, @dinocosta , You are right, only modify the environment variable in the |
Release Notes:
before:
2026-03-10.18.19.49.mov
after:
2026-03-10.18.21.25.mov