feat(session-manager): allow Ctrl n and Ctrl p in attach to session to navigate items

[anopheles]

Readlines, https://readline.kablamo.org/emacs.html, uses Ctrl + n/p to

Fetch the previous/next command from the history list.

Using this in the session manager is an obvious choice, especially as key mappings can't be configured.

Addresses #2740

Unfortunately, ctrl+hjkl doesn't seem to work in this context.

[Zykino]

Ctrl+p is already bind to start the pane mode -> This is a conflicting default keybindings.

Also, since all you change is in the config, feel free to fork the session-manager. I’m not sure exactly how to do it, but it should be possible to give the keybindings you want to use as configuration at load.

For an example on how to get the config see:

zellij/default-plugins/session-manager/src/main.rs

Lines 54 to 58 in 95ea75b

	fn load(&mut self, configuration: BTreeMap<String, String>) {
	self.is_welcome_screen = configuration
	.get("welcome_screen")
	.map(|v| v == "true")
	.unwrap_or(false);

[anopheles]

Ctrl+p is already bind to start the pane mode -> This is a conflicting default keybindings.

Good observation. The arrow keys, which the session manager currently uses for navigation, is also already used in various contexts. I therefore don't see it as a problem. If a user uses the session-manager all keys are handled by the plugin, until it exits (as far as I can tell).

Also, since all you change is in the config, feel free to fork the session-manager.

I hoped to merge this into the zellij main repository. As I expect the session-manager to evolve in the next couple of months, I am unable to invest capacity to keep my fork in sync.

For an example on how to get the config see:

Thanks! I'll see what I can do.

Disclaimer: This is my first XP with rust :)

[anopheles]

Does someone have any pointers to due something like this in the plugin section?

session-manager location="zellij:session-manager" {
        bind "Ctrl n" { MoveSelectionUp; }
        bind "Ctrl p" { MoveSelectionDown; }
    }

configuration: BTreeMap<String, String> only seems to store string values.

Or what would be your preferred implementation strategy here?

[towry]

@anopheles Does this pr solve this conflict issue? #3422

[anopheles]

@anopheles Does this pr solve this conflict issue? #3422

I don't think so. This PR just adds Ctrl + n/p navigation to the session navigator. I don't see how #3422 can solve this, but don't take my word for it.