Skip to content

Commit

Permalink
Merge pull request #390 from zendesk/luis.setup_improvements
Browse files Browse the repository at this point in the history
Setup improvements
  • Loading branch information
luis-almeida authored Jul 19, 2023
2 parents b32c852 + 21a8185 commit f609ea3
Show file tree
Hide file tree
Showing 11 changed files with 78 additions and 25,911 deletions.
3 changes: 2 additions & 1 deletion .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
"extends": [
"eslint:recommended",
"plugin:prettier/recommended",
"plugin:import/recommended"
"plugin:import/recommended",
"plugin:react/recommended"
],
"env": {
"browser": true
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,5 @@ node_modules/
.zat
script.js
style.css
assets/
*.DS_Store
2 changes: 1 addition & 1 deletion .releaserc
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"prepareCmd": "./bin/update-manifest-version.sh ${nextRelease.version}"
}],
["@semantic-release/git", {
"assets": ["manifest.json", "script.js", "style.css", "CHANGELOG.md"],
"assets": ["manifest.json", "script.js", "style.css", "assets", "CHANGELOG.md"],
"message": "chore(release): ${nextRelease.version}\n\n${nextRelease.notes}"
}],
"@semantic-release/github"
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ This will compile all the source code in `src` and `styles` and watch for change
Notes:

- We intentionally do not use babel so we can get a clean bundle output. Make sure to only use widely supported ecmascript features (ES2015).
- Both `style.css` and `script.js` are ignored as they'll be regenerated during release. Do not edit these directly.
- Both `style.css` and `script.js` (along with `assets`) are ignored as they'll be regenerated during release. Do not edit these directly.
- If you do want to test your changes by importing the branch in Theming Center, you'll need to manually add and commit these files, e.g. `git add -f script.js style.css`
- Preview requires login so make sure to first run `yarn zcli login -i` if you haven't done that before.

Expand Down
41 changes: 0 additions & 41 deletions assets/NewRequestForm.js

This file was deleted.

15 changes: 0 additions & 15 deletions assets/shared.js

This file was deleted.

Loading

0 comments on commit f609ea3

Please sign in to comment.