Skip to content

feat(settings): Add "show_new_request" check box to settings. #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(settings): Add "show_new_request" check box to settings. #288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,6 +384,18 @@
"value": true
}
]
},
{
"label": "navigation_settings_label",
"variables": [
{
"identifier": "show_new_request",
"type": "checkbox",
"description": "show_new_request_description",
"label": "show_new_request_label",
"value": true
}
]
}
]
}
}
117 changes: 62 additions & 55 deletions templates/header.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,95 +3,102 @@
<header class="header">
<div class="logo">
{{#link 'help_center'}}
<img src="{{settings.logo}}" alt="{{t 'home_page' name=help_center.name}}" />
{{#if settings.show_brand_name}}
<span aria-hidden="true">{{help_center.name}}</span>
{{/if}}
<img src="{{settings.logo}}" alt="{{t 'home_page' name=help_center.name}}" />
{{#if settings.show_brand_name}}
<span aria-hidden="true">{{help_center.name}}</span>
{{/if}}
{{/link}}
</div>

<div class="nav-wrapper-desktop">
<nav class="user-nav" id="user-nav">
<ul class="user-nav-list">
<li>{{link 'community'}}</li>
{{#if settings.show_new_request}}
<li>{{link 'new_request' class='submit-a-request'}}</li>
{{/if}}
{{#unless signed_in}}
<li>
{{#link "sign_in" class="sign-in"}}
{{t 'sign_in'}}
{{/link}}
</li>
<li>
{{#link "sign_in" class="sign-in"}}
{{t 'sign_in'}}
{{/link}}
</li>
{{/unless}}
</ul>
</nav>
{{#if signed_in}}
<div class="user-info dropdown">
<button class="dropdown-toggle" aria-haspopup="true">
{{user_avatar class="user-avatar"}}
<span>
{{user_name}}
<svg xmlns="http://www.w3.org/2000/svg" width="12" height="12" focusable="false" viewBox="0 0 12 12" class="dropdown-chevron-icon" aria-hidden="true">
<path fill="none" stroke="currentColor" stroke-linecap="round" d="M3 4.5l2.6 2.6c.2.2.5.2.7 0L9 4.5"/>
</svg>
</span>
</button>
<div class="dropdown-menu" role="menu">
{{#my_profile role="menuitem"}}{{t 'profile'}}{{/my_profile}}
{{link "requests" role="menuitem"}}
{{#link "contributions" role="menuitem"}}{{t "activities"}}{{/link}}
{{contact_details role="menuitem"}}
{{change_password role="menuitem"}}
{{link "sign_out" role="menuitem"}}
</div>
<div class="user-info dropdown">
<button class="dropdown-toggle" aria-haspopup="true">
{{user_avatar class="user-avatar"}}
<span>
{{user_name}}
<svg xmlns="http://www.w3.org/2000/svg" width="12" height="12" focusable="false" viewBox="0 0 12 12"
class="dropdown-chevron-icon" aria-hidden="true">
<path fill="none" stroke="currentColor" stroke-linecap="round" d="M3 4.5l2.6 2.6c.2.2.5.2.7 0L9 4.5" />
</svg>
</span>
</button>
<div class="dropdown-menu" role="menu">
{{#my_profile role="menuitem"}}{{t 'profile'}}{{/my_profile}}
{{link "requests" role="menuitem"}}
{{#link "contributions" role="menuitem"}}{{t "activities"}}{{/link}}
{{contact_details role="menuitem"}}
{{change_password role="menuitem"}}
{{link "sign_out" role="menuitem"}}
</div>
</div>
{{/if}}
</div>

<div class="nav-wrapper-mobile">
<button class="menu-button-mobile" aria-controls="user-nav-mobile" aria-expanded="false" aria-label="{{t 'toggle_navigation'}}">
<button class="menu-button-mobile" aria-controls="user-nav-mobile" aria-expanded="false"
aria-label="{{t 'toggle_navigation'}}">
{{#if signed_in}}
{{user_avatar class="user-avatar"}}
{{user_avatar class="user-avatar"}}
{{/if}}
<svg xmlns="http://www.w3.org/2000/svg" width="16" height="16" focusable="false" viewBox="0 0 16 16" class="icon-menu">
<path fill="none" stroke="currentColor" stroke-linecap="round" d="M1.5 3.5h13m-13 4h13m-13 4h13"/>
<svg xmlns="http://www.w3.org/2000/svg" width="16" height="16" focusable="false" viewBox="0 0 16 16"
class="icon-menu">
<path fill="none" stroke="currentColor" stroke-linecap="round" d="M1.5 3.5h13m-13 4h13m-13 4h13" />
</svg>
</button>
<nav class="menu-list-mobile" id="user-nav-mobile" aria-expanded="false">
<ul class="menu-list-mobile-items">
{{#if signed_in}}
<li class="user-avatar-item item">
{{#my_profile role="menuitem" class="my-profile"}}
{{user_avatar class="menu-profile-avatar"}}
<div class="menu-profile-name">
<div>{{user_name}}</div>
<div class="my-profile-tooltip">{{t 'profile'}}</div>
</div>
{{/my_profile}}
</li>
<li class="item">{{link "requests" role="menuitem"}}</li>
<li class="item">{{#link "contributions" role="menuitem"}}{{t "activities"}}{{/link}}</li>
<li class="item">{{contact_details role="menuitem"}}</li>
<li class="item">{{change_password role="menuitem" class='change-password'}}</li>
<li class="nav-divider"></li>
<li class="user-avatar-item item">
{{#my_profile role="menuitem" class="my-profile"}}
{{user_avatar class="menu-profile-avatar"}}
<div class="menu-profile-name">
<div>{{user_name}}</div>
<div class="my-profile-tooltip">{{t 'profile'}}</div>
</div>
{{/my_profile}}
</li>
<li class="item">{{link "requests" role="menuitem"}}</li>
<li class="item">{{#link "contributions" role="menuitem"}}{{t "activities"}}{{/link}}</li>
<li class="item">{{contact_details role="menuitem"}}</li>
<li class="item">{{change_password role="menuitem" class='change-password'}}</li>
<li class="nav-divider"></li>
{{else}}
<li class="item">
{{#link "sign_in" role="menuitem"}}
{{t 'sign_in'}}
{{/link}}
</li>
<li class="nav-divider"></li>
<li class="item">
{{#link "sign_in" role="menuitem"}}
{{t 'sign_in'}}
{{/link}}
</li>
<li class="nav-divider"></li>
{{/if}}
<li class="item">{{link 'community' role="menuitem"}}</li>
{{#if settings.show_new_request}}
<li class="item">{{link 'new_request' role="menuitem" class='submit-a-request'}}</li>
{{/if}}
<li class="nav-divider"></li>
{{#if signed_in}}
<li class="item">
{{link "sign_out" role="menuitem"}}
</li>
<li class="item">
{{link "sign_out" role="menuitem"}}
</li>
{{/if}}
</li>
</ul>
</nav>
</div>

</header>
</header>
16 changes: 16 additions & 0 deletions translations.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,3 +365,19 @@ parts:
title: "Description for the show brand name setting"
screenshot: "https://drive.google.com/file/d/16zQao3zk3uRScIUpkyc6bXAWwqHh3Zh-/view?usp=sharing"
value: "Display the Help Center name next to the logo"
- translation:
key: "txt.help_center_copenhagen_theme.navigation_settings_label"
title: "Label for navigation settings group"
screenshot: "https://drive.google.com/file/d/1Rk7x7YrGfKvgivs1fXcjrsIjZ2EchWTh/view"
value: "Navigation Settings"
- translation:
key: "txt.help_center_copenhagen_theme.show_new_request_label"
title: "Label for the show new request link setting"
screenshot: "https://drive.google.com/file/d/1Rk7x7YrGfKvgivs1fXcjrsIjZ2EchWTh/view"
value: "Submit a request"
- translation:
key: "txt.help_center_copenhagen_theme.show_new_request_description"
title: "Description for the show new request link setting"
screenshot: "https://drive.google.com/file/d/1Rk7x7YrGfKvgivs1fXcjrsIjZ2EchWTh/view"
value: "Show submit a request link in the navigation"

7 changes: 5 additions & 2 deletions translations/en-us.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,5 +66,8 @@
"follow_topic_label": "Follow",
"follow_topic_description": "Users can follow a specific topic",
"show_brand_name_label": "Show Help Center name",
"show_brand_name_description": "Display the Help Center name next to the logo"
}
"show_brand_name_description": "Display the Help Center name next to the logo",
"navigation_settings_label": "Navigation Settings",
"show_new_request_label": "Submit a request",
"show_new_request_description": "Show the submit a request link in the navigation"
}
7 changes: 5 additions & 2 deletions translations/en-x-keys.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,8 @@
"community_background_image_description": "txt.help_center_copenhagen_theme.community_background_image_description",
"community_background_image_label": "txt.help_center_copenhagen_theme.community_background_image_label",
"community_image_description": "txt.help_center_copenhagen_theme.community_image_description",
"community_image_label": "txt.help_center_copenhagen_theme.community_image_label"
}
"community_image_label": "txt.help_center_copenhagen_theme.community_image_label",
"navigation_settings_label": "txt.help_center_copenhagen_theme.navigation_settings_label",
"show_new_request_label": "txt.help_center_copenhagen_theme.show_new_request_label",
"show_new_request_description": "txt.help_center_copenhagen_theme.show_new_request_description"
}