Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide generated files instead of ignoring #394

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Conversation

luis-almeida
Copy link
Contributor

Description

Compiled assets are regenerated upon every release. However, for side-running branches, or simply to be able to import a themes containing the latest changes, it's easier to not ignore compiled files.
This PR moves them to .gitattributes and set them as generated so they're always hidden by default in PRs.

Checklist

  • 📗 all commit messages follow the conventional commits standard
  • ⬅️ changes are compatible with RTL direction
  • ♿ Changes to the UI are tested for accessibility and compliant with WCAG 2.1.
  • 📝 changes are tested in Chrome, Firefox, Safari and Edge
  • 📱 changes are responsive and tested in mobile
  • 👍 PR is approved by @zendesk/vikings

Copy link
Contributor

@anpa anpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find! Let's try it out!

@luis-almeida luis-almeida marked this pull request as ready for review July 25, 2023 14:07
@luis-almeida luis-almeida requested a review from a team as a code owner July 25, 2023 14:07
@luis-almeida luis-almeida merged commit 690defc into v4-alpha Jul 25, 2023
2 checks passed
@luis-almeida luis-almeida deleted the luis.gitattributes branch July 25, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants