Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rendering DropDown and TextArea ticket fields #397

Merged
merged 6 commits into from
Jul 28, 2023
Merged

Rendering DropDown and TextArea ticket fields #397

merged 6 commits into from
Jul 28, 2023

Conversation

luis-almeida
Copy link
Contributor

Description

  • Adding a basic DropDown component
    • We might want to streamline and just use the same as for the ticket form field selector but I thought it was worth it to start with this one for ticket fields.
  • Adding a basic TextArea component
  • Rendering anonymous_requester_email, description and textarea type fields

Handling of state and submission in a follow up PR.

Checklist

  • 📗 all commit messages follow the conventional commits standard
  • ⬅️ changes are compatible with RTL direction
  • ♿ Changes to the UI are tested for accessibility and compliant with WCAG 2.1.
  • 📝 changes are tested in Chrome, Firefox, Safari and Edge
  • 📱 changes are responsive and tested in mobile
  • 👍 PR is approved by @zendesk/vikings

@luis-almeida luis-almeida requested a review from a team as a code owner July 27, 2023 14:15
Fredx87
Fredx87 reviewed Jul 27, 2023
View reviewed changes
src/modules/new-request-form/fields/DropDown.tsx Outdated Show resolved Hide resolved
templates/new_request_page.hbs Outdated Show resolved Hide resolved
@luis-almeida
Copy link
Contributor Author

@Fredx87 thanks for the review! I addressed your comments so ready for another go 🙏🏼

Fredx87
Fredx87 approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@Fredx87 Fredx87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@luis-almeida luis-almeida merged commit fe0ed34 into v4-alpha Jul 28, 2023
2 checks passed
@luis-almeida luis-almeida deleted the luis.more_ticket_field_types branch July 28, 2023 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fredx87 Fredx87 Fredx87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luis-almeida @Fredx87