feat: validate CC tag when leaving the field #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Was the previous behaviour to also keep the focus on the field even after the the |
Nope. Need to fix that. Thank you @luis-almeida! |
BrunoBFerreira
force-pushed
the
brunobferreira/GG-3804/update-cc-field-behavior-for-v4
branch
from
431f25f
to
2729a35
Compare
|
I believe it should be solved @luis-almeida. Could you take another look? 🙏 |
luis-almeida
approved these changes
Oct 3, 2024
BrunoBFerreira
deleted the
brunobferreira/GG-3804/update-cc-field-behavior-for-v4
branch
|
🎉 This PR is included in version 4.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When we updated for v4, we changed the behavior of the CC field slightly. Before, if we clicked outside the input box, we would validate the current string and turn it into a tag, when valid. Currently, we are not doing that and we are just saving the input.
Since this feature is useful for our users, we are re-adding this feature in this PR.
JIRA: GG-3804
Screenshots
Need to convert this to a gif
Screen.Recording.2024-10-02.at.16.05.17.mov
Checklist