Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add suit options #19

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

tomkennedy22
Copy link
Contributor

Not a real use case for this right now, but figured I would offer it up as a 'jersey' option. This PR adds in 2 new jerseys, 'suit' and 'suit2'. I thought maybe a suit would make sense if you ever include owners, coaches, GMs, or whatever. Or perhaps it would look good on free agents or retired players.

I added logic to remove a player's headband, facemask, glasses, etc if they're wearing a suit. With the first suit option, the player's tie will be solid in the team's primary color. Suit2 has primary color tie, with white and secondary color stripes.

Below are examples for both, tested in my local editor.html yarn run. Please note - when testing this I got a javascript error stating 'variable faces does not exist' on line 787 of editor.html, but upon re-starting yarn the error disappeared. Not sure if that is a real issue.

image

image

@dumbmatter
Copy link
Member

This is really cool, thanks!

I will probably not merge this until I have a use for it in BBGM (which I probably should at some point, would be fun to have a GM character you can make for yourself, or maybe a coach). Cause until then it's just increasing the file size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants