Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add my duck #423

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

nandakishore-dasari
Copy link

Description

Here my contribution to "The Duck Gallery".

You must respect the following conditions

  1. Your contribution must respect the code of conduct
  2. It's your first PR to this repository
  3. You have added your image of the duck downloaded from https://pimpmyduck.zenika.com
  4. You have not changed the image of the duck
  5. The image filename must be your GitHub username (ex: your-username.png)
  6. You are using your own GitHub user and it's the same as the PR author
  7. Into the contributors.js file, the message must be short and respect the code of conduct

If the PR doesn't respect those conditions, it will be closed

@@ -63,6 +63,7 @@ const contributors = [
{ username: 'anushkabhansalii', message: 'Keep smiling!' },
{ username: 'sohailshk', message: 'First pr hopefully for hacktoberfest2024' },
{ username: 'snehachandra1108', message: 'First Hacktober' },
{ username: 'nandakishore-dasari', message: 'first open source contri'},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thanks for your contribution. There is a problem on your duck file name.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey, my duck file name is my username, can you please specify where is the error and how to fix it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nandakishore-dasari, the extension .png appears twice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants