Add my duck #443
Merged
Add my duck #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @RJSIN147 , please add your name on the contributor file, without it, your duck will not be displayed on the website 😁 |
|
Added my name in the contributor file. Thanks for the reminder @jeanphi-baconnais . |
contributors.js
Outdated
| @@ -75,4 +75,5 @@ const contributors = [ | |||
| { username: 'Yeashu', message: 'Hello Hacktoberfest. Here my journey begin'}, | |||
| { username: 'sanaa-duhh', message: 'starting my hacktoberfest journey with this one'}, | |||
| { username: 'SayedZahur786', message: 'Hello Zenika, Thanks for this Pr'} | |||
There was a problem hiding this comment.
there is another thing to before accepting your PR, fix the json file adding a comma please
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Here my contribution to "The Duck Gallery".
You must respect the following conditions
your-username.png)contributors.jsfile, the message must be short and respect the code of conductIf the PR doesn't respect those conditions, it will be closed