Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR moves the Quickstart files into the devcontainer to streamline workspace startup and updates the related configuration files accordingly. Key changes include relocating source files, updating devcontainer paths, and revising pipeline configurations.
Reviewed Changes
Copilot reviewed 58 out of 58 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| quickstartModules/utils/preprocess.py | Added utility classes for preprocessing. |
| quickstartModules/steps/* | Added multiple ML pipeline steps for data loading, preprocessing, training, evaluation, promotion, inference, and splitting. |
| quickstartModules/pipelines/* | Introduced training, inference, and feature engineering pipelines. |
| quickstartModules/configs/* | Added YAML configuration files for different training modes and inference. |
| devcontainer.json | Updated PYTHONPATH and workspaceFolder to reflect new file structure. |
Comment on lines
+94
to
+96
| else: | ||
| for message in messages: | ||
| logger.warning(message) |
There was a problem hiding this comment.
The current else block only logs warnings when the test accuracy meets the minimum criteria, potentially skipping warnings for a lower training accuracy. Consider separating the logging of train and test warnings so that both conditions are logged independently.
Suggested change
| else: | |
| for message in messages: | |
| logger.warning(message) | |
| for message in messages: | |
| logger.warning(message) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Places all the Quickstart files within the devcontainer for faster/smoother workspace startup.
devcontainer.jsonconfigs are correspondingly updated as well.