Skip to content

Comments

Move sections to devcontainer#7

Open
Jay-rh wants to merge 8 commits intodevelopfrom
move-sections-to-devcontainer
Open

Move sections to devcontainer#7
Jay-rh wants to merge 8 commits intodevelopfrom
move-sections-to-devcontainer

Conversation

@Jay-rh
Copy link
Collaborator

@Jay-rh Jay-rh commented Aug 1, 2024

Places all the Quickstart files within the devcontainer for faster/smoother workspace startup.

devcontainer.json configs are correspondingly updated as well.

@strickvl strickvl requested a review from Copilot May 24, 2025 11:33
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR moves the Quickstart files into the devcontainer to streamline workspace startup and updates the related configuration files accordingly. Key changes include relocating source files, updating devcontainer paths, and revising pipeline configurations.

Reviewed Changes

Copilot reviewed 58 out of 58 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
quickstartModules/utils/preprocess.py Added utility classes for preprocessing.
quickstartModules/steps/* Added multiple ML pipeline steps for data loading, preprocessing, training, evaluation, promotion, inference, and splitting.
quickstartModules/pipelines/* Introduced training, inference, and feature engineering pipelines.
quickstartModules/configs/* Added YAML configuration files for different training modes and inference.
devcontainer.json Updated PYTHONPATH and workspaceFolder to reflect new file structure.

Comment on lines +94 to +96
else:
for message in messages:
logger.warning(message)
Copy link

Copilot AI May 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current else block only logs warnings when the test accuracy meets the minimum criteria, potentially skipping warnings for a lower training accuracy. Consider separating the logging of train and test warnings so that both conditions are logged independently.

Suggested change
else:
for message in messages:
logger.warning(message)
for message in messages:
logger.warning(message)

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant