Allow modifying remote/project urls of imported manifests #869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #869 +/- ##
==========================================
+ Coverage 84.40% 84.53% +0.13%
==========================================
Files 11 11
Lines 3385 3408 +23
==========================================
+ Hits 2857 2881 +24
+ Misses 528 527 -1
|
thorsten-klein
force-pushed
the
override-remotes
branch
from
d35e837 to
d12eb95
Compare
thorsten-klein
changed the title
Add support for a new 'import-modifications' section in the manifest. Under the 'url-replace' key, users can define search-and-replace patterns that are applied to project URLs during manifest import. This allows downstream projects to modify remote URLs, e.g. when using mirrored repositories.
Test that import-modifications feature works to override west project urls that directly specified in west manifest or imported via submanifests.
thorsten-klein
force-pushed
the
override-remotes
branch
from
d12eb95 to
bc81ddf
Compare
Collaborator
|
Do you think you could focus on the Obviously, your #867 will make this even easier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal for #615
Support is added for a new
import-modificationssection in the west manifest.Under the
url-replacekey, users can define search-and-replace patterns that are applied to project URLs during manifest import. This allows downstream projects to modify remote URLs, e.g. when using mirrored repositories.