pyproject.toml: add new poe target "types-extra" #875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As kindly suggested by the existing "types" target: $ uv run poe types Poe => mypy --package west src/west/app/project.py:1364: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs [annotation-unchecked] Do not include in the "all" group because it's not passing. Signed-off-by: Marc Herbert <[email protected]>
This was the only --check-untyped-defs warning in manifest.py: easy win. Signed-off-by: Marc Herbert <[email protected]>
marc-hb
commented
Nov 4, 2025
| def get(self, option, **kwargs): | ||
| def get( | ||
| self, option: str, default: str | None = None, configfile: ConfigFile = ConfigFile.ALL | ||
| ) -> str | None: |
Collaborator
Author
There was a problem hiding this comment.
This is a public, documented method so it's not going to change any time soon.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #875 +/- ##
=======================================
Coverage 84.40% 84.40%
=======================================
Files 11 11
Lines 3385 3385
=======================================
Hits 2857 2857
Misses 528 528
|
Collaborator
Author
|
Current output cc: @thorsten-klein |
Collaborator
Author
|
Then, maybe we could run this failing checkin in CI with a Similarly to 361004d? I forgot how that went. Either way this can be merged first. |
pdgendt
approved these changes
Nov 4, 2025
Contributor
|
Why not enabling I will start fixing the issues on main👍 |
Collaborator
I'd also like it if the issues were dealt with, and we can simply enable the untyped checks in the |
Collaborator
Author
More importantly, because:
That's why this PR is not adding anything to CI. If you want the extra, unfixable warnings then it's now very easy to see them. If you don't, then just keep ignoring as you've been doing before. The same "extra" logic could apply to other options than --check-untyped-defs - even if all --check-untyped-defs turn out to be fixable. BTW there are --check-untyped-defs warnings in only three files (the bigger and more complex ones), so it's easy to spot warnings in other files. That's one value of |
Collaborator
Author
Great but please avoid git conflicts with PRs currently in progress (unless it's an actual bug and not just a warning). EDIT, see: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As kindly suggested by the existing "types" target: