Skip to content

drivers: i2c: Fix BFLB I2C again again #102033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
VynDragon wants to merge 1 commit into
base: main
Choose a base branch
from
Open

drivers: i2c: Fix BFLB I2C again again #102033

VynDragon wants to merge 1 commit into from
+3 −4

Conversation

@VynDragon
Copy link
Contributor

@VynDragon VynDragon commented Jan 9, 2026

Maybe the last time? associated issue outlines details

@VynDragon
drivers: i2c: Fix BFLB I2C again again
70131ad 
Maybe the last time? associated issue outlines details

Signed-off-by: Camille BAUD <[email protected]>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 9, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@VynDragon VynDragon mentioned this pull request Jan 9, 2026
Open
1 task
@VynDragon VynDragon linked an issue Jan 9, 2026 that may be closed by this pull request
Recurrent compiler optimization related failure of BFLB I2C driver #102040
Open
1 task
@VynDragon VynDragon marked this pull request as ready for review January 9, 2026 16:21
@zephyrbot zephyrbot requested review from josuah and teburd January 9, 2026 16:23
josuah
josuah approved these changes Jan 9, 2026
View reviewed changes
Copy link
Contributor

@josuah josuah left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still puzzled to see this driver being affected by the compiler reordering everything.

Maybe there is some other bug somewhere, I remember you saying the disassembly was shuffling things a lot and that volatile everything was not a complete fix. But it could also be a compiler design choice or plain bug, so if this is possible to fix it at the driver level in the meantime it's good IMHO.

Context is, IIRC Zephyr SDK 0.17.4.

@hamoodmohameed16-source
Copy link

hamoodmohameed16-source commented Jan 10, 2026

Maybe the last time? associated issue outlines details

Still puzzled to see this driver being affected by the compiler reordering everything.

Maybe there is some other bug somewhere, I remember you saying the disassembly was shuffling things a lot and that volatile everything was not a complete fix. But it could also be a compiler design choice or plain bug, so if this is possible to fix it at the driver level in the meantime it's good IMHO.

Context is, IIRC Zephyr SDK 0.17.4.

@hamoodmohameed16-source
Copy link

hamoodmohameed16-source commented Jan 10, 2026

[ ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@teburd teburd teburd approved these changes

@josuah josuah josuah approved these changes

Assignees

@VynDragon VynDragon

Labels

area: I2C platform: Bouffalo Lab

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Recurrent compiler optimization related failure of BFLB I2C driver

5 participants

@VynDragon @hamoodmohameed16-source @teburd @josuah @zephyrbot