drivers: lora: rename loramac_node directory to loramac-node #102035
Conversation
zephyrbot
requested review from
FRASTM,
GeorgeCGV,
JordanYates,
djiatsaf-st,
erwango,
etienne-lms,
gautierg-st,
juickar,
martinjaeger,
mathieuchopstm and
mniestroj
carlocaione
force-pushed
the
upstream/lorawan_fix_naming
branch
from
3a167d7 to
8e80d98
Compare
| set(ZEPHYR_CURRENT_LIBRARY lora-basics-modem) | ||
| else() | ||
| zephyr_library_named(lora_basics_modem) | ||
| zephyr_library_named(lora-basics-modem) |
There was a problem hiding this comment.
this breaks out of tree users (if someone was using zephyr_library_amend), though I have no suggestion for a way to work around that
There was a problem hiding this comment.
yes, that sucks. Alright then, I'll keep lora_basics_modem but at least I'll fix s/loramac_node/loramac-node, it is a bit unfortunate that the module name for lora-basics-modem will keep to be inconsistent.
There was a problem hiding this comment.
I guess if the maintainers think it's unlikely that it's been amended out of tree then the breaking change process could be followed to change it, it's only been in for the 4.3 release. Actually, it's fine to change, 38384e1#diff-c82e5f446b92db2320763180d4890fc1fc4008c8514e1711ecc1d233f72a0312R25-R31 it's listed as experimental so go right ahead
Rename drivers/lora/loramac_node to drivers/lora/loramac-node to align with the module naming convention (modules/loramac-node). Signed-off-by: Carlo Caione <[email protected]>
carlocaione
force-pushed
the
upstream/lorawan_fix_naming
branch
from
8e80d98 to
ccfcbb1
Compare
carlocaione
changed the title
|
5 participants
Rename
drivers/lora/loramac_nodetodrivers/lora/loramac-nodeto align with the module naming convention (modules/loramac-node).