Skip to content

[Backport v4.1-branch] drivers: entropy: Fix non-stop RNG ISR firing for STM32WB09 #99162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: v4.1-branch
Choose a base branch
from
Open

[Backport v4.1-branch] drivers: entropy: Fix non-stop RNG ISR firing for STM32WB09 #99162

wants to merge 2 commits into from

Conversation

@HoZHel
Copy link
Contributor

@HoZHel HoZHel commented Nov 10, 2025 •
edited
Loading

Backport from #98151 with excluding the third commit as it does not compatible with v4.1.

Modification w.r.t the original PR:

  • Replace stm32_reg_write with WRITE_REG.

Fixes #98617 and #98668 for the backport v4.1

HoZHel added 2 commits November 7, 2025 20:47
@HoZHel
drivers: entropy: Fix non-stop RNG ISR firing for STM32WB09
f9e62be 
Fix the TRNG driver issue regarding non-stop ISR firing for STM32WB09 by
clearing RNG_IRQ_SR_ERROR_IRQ flag.

Signed-off-by: Ali Hozhabri <[email protected]>
@HoZHel
drivers: entropy: Modify the recover_seed_error function for WB0x
c71448f 
Exclude the WB0x series from discarding data 12 times from the RNG data
register.

Add a comment to the recover_seed_error function explaining the reason
for reading and discarding data from the RNG data register 12 times.

Signed-off-by: Ali Hozhabri <[email protected]>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 10, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@HoZHel HoZHel marked this pull request as ready for review November 10, 2025 15:59
@HoZHel HoZHel requested a review from etienne-lms November 10, 2025 16:03
@mathieuchopstm
Copy link
Contributor

mathieuchopstm commented Nov 10, 2025

For the record, can you explain as a comment here why the third commit (change DT_DRV_INST(0) -> DT_CHOSEN(zephyr_entropy)) is not compatible with 4.1?

@HoZHel
Copy link
Contributor Author

HoZHel commented Nov 11, 2025

For the record, can you explain as a comment here why the third commit (change DT_DRV_INST(0) -> DT_CHOSEN(zephyr_entropy)) is not compatible with 4.1?

In that time, rng_get_random() wasn't introduced in the BLE driver, and the configuration and use of RNG peripheral for BLE applications were done by WB0 lib available in modules/hal/stm32/lib/stm32wb0.
This backport to v4.1 impacts non-BLE applications using RNG peripheral.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mathieuchopstm mathieuchopstm mathieuchopstm approved these changes

@ceolin ceolin Awaiting requested review from ceolin

@djiatsaf-st djiatsaf-st Awaiting requested review from djiatsaf-st

@erwango erwango Awaiting requested review from erwango

@FRASTM FRASTM Awaiting requested review from FRASTM

@gautierg-st gautierg-st Awaiting requested review from gautierg-st

@GeorgeCGV GeorgeCGV Awaiting requested review from GeorgeCGV

@marwaiehm-st marwaiehm-st Awaiting requested review from marwaiehm-st

@tomi-font tomi-font Awaiting requested review from tomi-font

@etienne-lms etienne-lms Awaiting requested review from etienne-lms

At least 2 approving reviews are required to merge this pull request.

Assignees

@erwango erwango

Labels

area: Crypto / RNG platform: STM32 ST Micro STM32

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@HoZHel @mathieuchopstm @erwango @zephyrbot