stm32g4 opamp support #99181
Open
stm32g4 opamp support #99181
+2,070
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
set the default functional mode of OPAMP peripherals to "follower" Signed-off-by: Alexander Kozhinov <[email protected]>
add OPAMP module description string and help Signed-off-by: Alexander Kozhinov <[email protected]>
make functional mode required add functional modes description with circuit examples Signed-off-by: Alexander Kozhinov <[email protected]>
enable logging add log buffer size and debug options and comment them Signed-off-by: Alexander Kozhinov <[email protected]>
show gain value at runtime as a starting use ADC calibration before conversion update README with sample gain prints Signed-off-by: Alexander Kozhinov <[email protected]>
This commit introduces the DT_INST_STRING_TOKEN_BY_IDX_OR and DT_INST_STRING_TOKEN_BY_IDX macros, which allows specifying a default value if the indexed string token is not defined. Signed-off-by: Alexander Kozhinov <[email protected]>
add tests for DT_STRING_TOKEN_BY_IDX_OR macro add tests for DT_INST_STRING_TOKEN_BY_IDX_OR macro Signed-off-by: Alexander Kozhinov <[email protected]>
common STM32 OPAMP properties (st,stm32-opamp.yaml) stm32g4-specific OPAMP configuration (st,stm32g4-opamp.yaml) Signed-off-by: Alexander Kozhinov <[email protected]>
add OPAMP1-6 peripheral nodes to STM32G4 device tree Signed-off-by: Alexander Kozhinov <[email protected]>
add Kconfig options for stm32 opamp driver add conditional source target to cmake file Signed-off-by: Alexander Kozhinov <[email protected]>
implement operational amplifier driver for stm32g4 series Signed-off-by: Alexander Kozhinov <[email protected]>
add NUCLEO-G474RE board overlay for OPAMP output_measure sample Signed-off-by: Alexander Kozhinov <[email protected]>
add nucleo_g474re OPAMP to build_all driver test suite. Signed-off-by: Alexander Kozhinov <[email protected]>
add nucleo_g474re OPAMP support to the generic opamp_api test Signed-off-by: Alexander Kozhinov <[email protected]>
add extensive test suite for nucleo_g474re OPAMP driver covering most features and configurations. Signed-off-by: Alexander Kozhinov <[email protected]>
zephyrbot
added
platform: STM32
zephyrbot
requested review from
DerekSnell,
EmilioCBen,
butok,
decsny,
djiatsaf-st and
dleach02
zephyrbot
requested review from
FRASTM,
GeorgeCGV,
ZhaoxiangJin,
erwango,
etienne-lms,
gautierg-st,
juickar,
mathieuchopstm and
mmahadevan108
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds stm32g4 opamp including following features implemented:
I am highly appreciating any well structured review especially due to the fact, that the documented behavior of opamp in RM0440 Rev. 9 was a kind of tricky to implement within existing opamp_api definition. But it looks good now.
Thank you for your reviews.
It is currently blocked by following PRs:
The changes from 1 & 2 PRs are included here too to allow CI to run successfully, but I will drop them after 1 & 2 were merged. Also 1 & 2 PRs shall be merged definitely before this PR.
Please do not review changes of PRs 1 & 2 here, instead follow the link to provide your review.