Feature/autoblack #237
Open
Feature/autoblack #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This dependency has been included in `blaskapp.py`, but it was not included in the Pipfile, causing problems when launching the server.
Black releases for some reason count as prereleases, hence the allow_prereleases=true flag for pipenv
This file contains hashes for reformatting commit(s) so they can be ignored in `git blame` output with the `--ignore-revs-file` option.
The remaining badge references the `main` branch
…feature/autoblack
|
nice job |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Format entire codebase to black and add a job to autoformat code to Black on push. Closes #91 .
I have tested it in my own fork and it works fine. Do we want to keep format fixups in their own separate commit? (this is the current behaviour in the job) Or rather amend the last commit in the push to include the format changes "silently"?
I have taken the liberty to remove the duplicate Coveralls badge in README.md - the remaining one references the
mainbranch. I can discard that change if needed, of course.