Skip to content

Conversation

@maomao94
Copy link

@maomao94 maomao94 commented Oct 25, 2024

Fix: serialization Error of Nacos Parameters (notLoadCacheAtStart, updateCacheWhenEmpty)

Greptile Summary

Fixed Nacos parameter serialization issues by adding 'string' tags to boolean fields in the target struct, ensuring proper handling of URL query parameters for configuration.

  • Modified zrpc/registry/nacos/target.go to add 'string' tag to NotLoadCacheAtStart and UpdateCacheWhenEmpty boolean fields
  • Added proper struct field alignment for improved code readability
  • Ensures consistent parameter handling between URL queries and environment variables

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant