Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an OSC message from a string #2288

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Conversation

sphaero
Copy link
Contributor

@sphaero sphaero commented Jun 19, 2024

Problem: it's not easy to create a message simply by describing it like how a message can be printed as a string
Solution: Add zosc_fromstring method enabling the creation of message from a string

Also added test code.

A message can be constructed as follows:

zosc_t* msg = zosc_fromstring("/stringmsg ihfdscF 32 64 1.100000 3.140000 hello q");

@sphaero
Copy link
Contributor Author

sphaero commented Jun 19, 2024

MacOS is failing mysteriously:

travis_fold:start:dependency.libzmqInstall dependency libzmq
travis_fold:end:dependency.libzmq
travis_fold:start:dependency.uuidInstall dependency uuid
travis_fold:end:dependency.uuid
travis_fold:start:dependency.systemdInstall dependency systemd
WARNING: Can not build prerequisite 'systemd'
because neither tarball nor repository sources are known for it,
and it was not installed as a package; this may cause the test to fail!
travis_fold:end:dependency.systemd
travis_fold:start:dependency.lz4Install dependency lz4
travis_fold:end:dependency.lz4
travis_fold:start:dependency.libcurlInstall dependency libcurl
travis_fold:end:dependency.libcurl
travis_fold:start:dependency.nssInstall dependency nss
WARNING: Can not build prerequisite 'nss'
because neither tarball nor repository sources are known for it,
and it was not installed as a package; this may cause the test to fail!
travis_fold:end:dependency.nss
travis_fold:start:dependency.libmicrohttpdInstall dependency libmicrohttpd
travis_fold:end:dependency.libmicrohttpd
travis_fold:start:build.draftBuild and check this project with DRAFT APIs
Wed Jun 19 14:21:37 UTC 2024: INFO: Starting build of currently tested project with DRAFT APIs...
Error: Process completed with exit code 1.

No idea why.

Valgrind check is failing on zhttp_client?

Windows is failing on missing libsodium

- Could NOT find sodium (missing: SODIUM_LIBRARIES SODIUM_INCLUDE_DIRS) 
CMake Error at CMakeLists.txt:283 (message):
  libsodium requested but not found, you may want to install libsodium and
  run cmake again
-- Configuring incomplete, errors occurred!

@sphaero
Copy link
Contributor Author

sphaero commented Jun 21, 2024

Trying to debug this. Macos has moved to macos14. Autogen is failing. No idea why

 + fold_start build.draft 'Build and check this project with DRAFT APIs'

+ set +x
+ echo ''
++ date
+ echo 'Fri Jun 21 12:30:08 UTC 2024: INFO: Starting build of currently tested project with DRAFT APIs...'
+ CCACHE_BASEDIR=/Users/runner/work/czmq/czmq/czmq
+ export CCACHE_BASEDIR
+ '[' default = default-with-docs ']'
+ '[' -n '' ']'
+ CONFIG_OPTS+=("${CONFIG_OPT_WERROR}")
+ ./autogen.sh
Fri Jun 21 12:30:08 UTC 2024: INFO: Starting build of currently tested project with DRAFT APIs...

@sphaero
Copy link
Contributor Author

sphaero commented Jul 2, 2024

Ok, problem found: zeromq/zproject#1337

Creating a separate PR to fix this

@sphaero sphaero force-pushed the zosc_fromstring branch from 13f4205 to eb9003d Compare July 2, 2024 17:43
@sphaero
Copy link
Contributor Author

sphaero commented Jul 2, 2024

rebased against master and regenerated from zproject as problems were fixed upstream

@bluca bluca merged commit c30a961 into zeromq:master Jul 3, 2024
41 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants