Implement read/write for ProvingKey and VerifyingKey #143
voidxnullAnnotations
7 errors and 38 warnings
|
unresolved imports `crate::circuit::bool`, `crate::circuit::cs`:
fawkes-crypto/src/core/signal.rs#L2
error[E0432]: unresolved imports `crate::circuit::bool`, `crate::circuit::cs`
--> fawkes-crypto/src/core/signal.rs:2:15
|
2 | circuit::{bool::CBool, cs::{CS, RCS}},
| ^^^^ ^^ could not find `cs` in `circuit`
| |
| could not find `bool` in `circuit`
|
|
unresolved imports `crate::circuit::bool`, `crate::circuit::cs`, `crate::circuit::num`:
fawkes-crypto/src/circuit/poseidon.rs#L2
error[E0432]: unresolved imports `crate::circuit::bool`, `crate::circuit::cs`, `crate::circuit::num`
--> fawkes-crypto/src/circuit/poseidon.rs:2:15
|
2 | circuit::{bool::CBool, cs::{CS, RCS}, num::CNum},
| ^^^^ ^^ ^^^ could not find `num` in `circuit`
| | |
| | could not find `cs` in `circuit`
| could not find `bool` in `circuit`
|
|
unresolved imports `crate::circuit::bool`, `crate::circuit::num`, `crate::circuit::cs`:
fawkes-crypto/src/circuit/mux.rs#L2
error[E0432]: unresolved imports `crate::circuit::bool`, `crate::circuit::num`, `crate::circuit::cs`
--> fawkes-crypto/src/circuit/mux.rs:2:15
|
2 | circuit::{bool::CBool, num::CNum, cs::CS},
| ^^^^ ^^^ ^^ could not find `cs` in `circuit`
| | |
| | could not find `num` in `circuit`
| could not find `bool` in `circuit`
|
|
unresolved imports `crate::circuit::bool`, `crate::circuit::num`, `crate::circuit::cs`:
fawkes-crypto/src/circuit/eddsaposeidon.rs#L4
error[E0432]: unresolved imports `crate::circuit::bool`, `crate::circuit::num`, `crate::circuit::cs`
--> fawkes-crypto/src/circuit/eddsaposeidon.rs:4:9
|
4 | bool::CBool,
| ^^^^ could not find `bool` in `circuit`
5 | ecc::CEdwardsPoint,
6 | num::CNum,
| ^^^ could not find `num` in `circuit`
7 | poseidon::c_poseidon,
8 | cs::CS,
| ^^ could not find `cs` in `circuit`
|
|
unresolved imports `crate::circuit::bool`, `crate::circuit::cs`, `crate::circuit::num`:
fawkes-crypto/src/circuit/ecc.rs#L4
error[E0432]: unresolved imports `crate::circuit::bool`, `crate::circuit::cs`, `crate::circuit::num`
--> fawkes-crypto/src/circuit/ecc.rs:4:15
|
4 | circuit::{bool::CBool, cs::{CS, RCS}, mux::c_mux3, num::CNum},
| ^^^^ ^^ ^^^ could not find `num` in `circuit`
| | |
| | could not find `cs` in `circuit`
| could not find `bool` in `circuit`
|
|
unresolved imports `crate::circuit::bool`, `crate::circuit::num`, `crate::circuit::cs`:
fawkes-crypto/src/circuit/bitify.rs#L4
error[E0432]: unresolved imports `crate::circuit::bool`, `crate::circuit::num`, `crate::circuit::cs`
--> fawkes-crypto/src/circuit/bitify.rs:4:15
|
4 | circuit::{bool::CBool, num::CNum, cs::CS},
| ^^^^ ^^^ ^^ could not find `cs` in `circuit`
| | |
| | could not find `num` in `circuit`
| could not find `bool` in `circuit`
|
|
check_and_test
Clippy had exited with the 101 exit code
|
|
constants have by default a `'static` lifetime:
fawkes-crypto/src/constants.rs#L2
warning: constants have by default a `'static` lifetime
--> fawkes-crypto/src/constants.rs:2:28
|
2 | pub const SEED_EDWARDS_G: &'static [u8] = b"edwards_g";
| -^^^^^^^----- help: consider removing `'static`: `&[u8]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
|
|
constants have by default a `'static` lifetime:
fawkes-crypto/src/constants.rs#L1
warning: constants have by default a `'static` lifetime
--> fawkes-crypto/src/constants.rs:1:29
|
1 | pub const PERSONALIZATION: &'static [u8; 8] = b"__fawkes";
| -^^^^^^^-------- help: consider removing `'static`: `&[u8; 8]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
= note: `#[warn(clippy::redundant_static_lifetimes)]` on by default
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
fawkes-crypto_derive/src/lib.rs#L161
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> fawkes-crypto_derive/src/lib.rs:161:41
|
161 | let var_typenames = get_field_types(&fields);
| ^^^^^^^ help: change this to: `fields`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
redundant closure:
fawkes-crypto_derive/src/lib.rs#L109
warning: redundant closure
--> fawkes-crypto_derive/src/lib.rs:109:14
|
109 | .map(|i| syn::Index::from(i))
| ^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `syn::Index::from`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
= note: `#[warn(clippy::redundant_closure)]` on by default
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
fawkes-crypto_derive/src/lib.rs#L107
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> fawkes-crypto_derive/src/lib.rs:107:41
|
107 | let var_typenames = get_field_types(&fields);
| ^^^^^^^ help: change this to: `fields`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
ff-uint_derive/src/lib.rs#L627
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> ff-uint_derive/src/lib.rs:627:37
|
627 | let montgomery_impl = mont_impl(&cratename, limbs);
| ^^^^^^^^^^ help: change this to: `cratename`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
ff-uint_derive/src/lib.rs#L626
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> ff-uint_derive/src/lib.rs:626:34
|
626 | let multiply_impl = mul_impl(&cratename, quote! {self}, quote! {other}, limbs);
| ^^^^^^^^^^ help: change this to: `cratename`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
ff-uint_derive/src/lib.rs#L625
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> ff-uint_derive/src/lib.rs:625:34
|
625 | let squaring_impl = sqr_impl(&cratename, quote! {self}, limbs);
| ^^^^^^^^^^ help: change this to: `cratename`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
redundant closure:
ff-uint_derive/src/lib.rs#L614
warning: redundant closure
--> ff-uint_derive/src/lib.rs:614:34
|
614 | (0..(limbs * 2)).map(|i| get_temp(i)),
| ^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `get_temp`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
|
|
redundant closure:
ff-uint_derive/src/lib.rs#L567
warning: redundant closure
--> ff-uint_derive/src/lib.rs:567:34
|
567 | (0..(limbs * 2)).map(|i| get_temp(i)),
| ^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `get_temp`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
= note: `#[warn(clippy::redundant_closure)]` on by default
|
|
manual implementation of an assign operation:
ff-uint_derive/src/lib.rs#L244
warning: manual implementation of an assign operation
--> ff-uint_derive/src/lib.rs:244:9
|
244 | t = t >> 1;
| ^^^^^^^^^^ help: replace it with: `t >>= 1`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
|
|
manual implementation of an assign operation:
ff-uint_derive/src/lib.rs#L178
warning: manual implementation of an assign operation
--> ff-uint_derive/src/lib.rs:178:9
|
178 | v = v >> 1;
| ^^^^^^^^^^ help: replace it with: `v >>= 1`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
|
|
manual implementation of an assign operation:
ff-uint_derive/src/lib.rs#L156
warning: manual implementation of an assign operation
--> ff-uint_derive/src/lib.rs:156:9
|
156 | v = v >> 64;
| ^^^^^^^^^^^ help: replace it with: `v >>= 64`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
|
|
unneeded `return` statement:
ff-uint_derive/src/lib.rs#L141
warning: unneeded `return` statement
--> ff-uint_derive/src/lib.rs:141:15
|
141 | }) => return s.value(),
| ^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
141 | }) => s.value(),
| ~~~~~~~~~
|
|
manual implementation of an assign operation:
ff-uint_derive/src/lib.rs#L87
warning: manual implementation of an assign operation
--> ff-uint_derive/src/lib.rs:87:13
|
87 | cur = cur << 64;
| ^^^^^^^^^^^^^^^ help: replace it with: `cur <<= 64`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
= note: `#[warn(clippy::assign_op_pattern)]` on by default
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
fawkes-crypto_derive/src/lib.rs#L161
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> fawkes-crypto_derive/src/lib.rs:161:41
|
161 | let var_typenames = get_field_types(&fields);
| ^^^^^^^ help: change this to: `fields`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
redundant closure:
fawkes-crypto_derive/src/lib.rs#L109
warning: redundant closure
--> fawkes-crypto_derive/src/lib.rs:109:14
|
109 | .map(|i| syn::Index::from(i))
| ^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `syn::Index::from`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
= note: `#[warn(clippy::redundant_closure)]` on by default
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
fawkes-crypto_derive/src/lib.rs#L107
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> fawkes-crypto_derive/src/lib.rs:107:41
|
107 | let var_typenames = get_field_types(&fields);
| ^^^^^^^ help: change this to: `fields`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`:
ff-uint/src/num/mod.rs#L297
warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
--> ff-uint/src/num/mod.rs:297:13
|
297 | / match Num::from_mont_uint(NumRepr(n)) {
298 | | Some(n) => return n,
299 | | _ => {}
300 | | }
| |_____________^ help: try: `if let Some(n) = Num::from_mont_uint(NumRepr(n)) { return n }`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
= note: `#[warn(clippy::single_match)]` on by default
|
|
unused import: `uint::macros::*`:
ff-uint/src/lib.rs#L50
warning: unused import: `uint::macros::*`
--> ff-uint/src/lib.rs:50:9
|
50 | pub use uint::macros::*;
| ^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
|
private item shadows public glob re-export:
ff-uint/src/lib.rs#L37
warning: private item shadows public glob re-export
--> ff-uint/src/lib.rs:37:1
|
37 | mod traits;
| ^^^^^^^^^^^
|
note: the name `traits` in the type namespace is supposed to be publicly re-exported here
--> ff-uint/src/lib.rs:48:9
|
48 | pub use ff::*;
| ^^^^^
note: but the private item here shadows it
--> ff-uint/src/lib.rs:37:1
|
37 | mod traits;
| ^^^^^^^^^^^
= note: `#[warn(hidden_glob_reexports)]` on by default
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
seedbox/src/lib.rs#L13
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> seedbox/src/lib.rs:13:24
|
13 | res.iter_mut().zip(hasher.finalize().into_iter()).for_each(|(l,r)| *l=r);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `hasher.finalize()`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/core/src/iter/traits/iterator.rs:643:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
|
|
constants have by default a `'static` lifetime:
seedbox/src/lib.rs#L7
warning: constants have by default a `'static` lifetime
--> seedbox/src/lib.rs:7:29
|
7 | pub const PERSONALIZATION: &'static [u8; 8] = b"__fawkes";
| -^^^^^^^-------- help: consider removing `'static`: `&[u8; 8]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
= note: `#[warn(clippy::redundant_static_lifetimes)]` on by default
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
ff-uint_derive/src/lib.rs#L627
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> ff-uint_derive/src/lib.rs:627:37
|
627 | let montgomery_impl = mont_impl(&cratename, limbs);
| ^^^^^^^^^^ help: change this to: `cratename`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
ff-uint_derive/src/lib.rs#L626
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> ff-uint_derive/src/lib.rs:626:34
|
626 | let multiply_impl = mul_impl(&cratename, quote! {self}, quote! {other}, limbs);
| ^^^^^^^^^^ help: change this to: `cratename`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
ff-uint_derive/src/lib.rs#L625
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> ff-uint_derive/src/lib.rs:625:34
|
625 | let squaring_impl = sqr_impl(&cratename, quote! {self}, limbs);
| ^^^^^^^^^^ help: change this to: `cratename`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
redundant closure:
ff-uint_derive/src/lib.rs#L614
warning: redundant closure
--> ff-uint_derive/src/lib.rs:614:34
|
614 | (0..(limbs * 2)).map(|i| get_temp(i)),
| ^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `get_temp`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
|
|
redundant closure:
ff-uint_derive/src/lib.rs#L567
warning: redundant closure
--> ff-uint_derive/src/lib.rs:567:34
|
567 | (0..(limbs * 2)).map(|i| get_temp(i)),
| ^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `get_temp`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
= note: `#[warn(clippy::redundant_closure)]` on by default
|
|
manual implementation of an assign operation:
ff-uint_derive/src/lib.rs#L244
warning: manual implementation of an assign operation
--> ff-uint_derive/src/lib.rs:244:9
|
244 | t = t >> 1;
| ^^^^^^^^^^ help: replace it with: `t >>= 1`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
|
|
manual implementation of an assign operation:
ff-uint_derive/src/lib.rs#L178
warning: manual implementation of an assign operation
--> ff-uint_derive/src/lib.rs:178:9
|
178 | v = v >> 1;
| ^^^^^^^^^^ help: replace it with: `v >>= 1`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
|
|
manual implementation of an assign operation:
ff-uint_derive/src/lib.rs#L156
warning: manual implementation of an assign operation
--> ff-uint_derive/src/lib.rs:156:9
|
156 | v = v >> 64;
| ^^^^^^^^^^^ help: replace it with: `v >>= 64`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
|
|
unneeded `return` statement:
ff-uint_derive/src/lib.rs#L141
warning: unneeded `return` statement
--> ff-uint_derive/src/lib.rs:141:15
|
141 | }) => return s.value(),
| ^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
141 | }) => s.value(),
| ~~~~~~~~~
|
|
manual implementation of an assign operation:
ff-uint_derive/src/lib.rs#L87
warning: manual implementation of an assign operation
--> ff-uint_derive/src/lib.rs:87:13
|
87 | cur = cur << 64;
| ^^^^^^^^^^^^^^^ help: replace it with: `cur <<= 64`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
= note: `#[warn(clippy::assign_op_pattern)]` on by default
|
|
check_and_test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
check_and_test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
check_and_test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
check_and_test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
check_and_test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|