restructuring the read_scf for stdoutSileSiesta #919
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #918 which cause erroneous reads because some details are stored after the scf: key.
Essentially the spin moment is consistently written after.
The current approach in read_scf, is to read data until it hits the same data-key again, at which point it serializes the data and stores it for further processing.
The logic has been streamlined and it should be simpler to follow and edit.
docs/
changes/<pr-num>.<type>.rst