Fully implemented spin-block rotation #930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #924. The problem was that the rotation should be performed using the Lie group SU(2) rotation matrix. This merge does a lot of things: 1. extends Quaternion to return norm2, rotation_matrix rotation_matrix_su2, rotation_vector. 2. A bug in reduction calls for sparse matrices that are complex. It had used the wrong data-type. 3. Generalized rotation arguments to allow more, and simpler rotations. Now the rotations can be any of: - 3 floats: angles for each Cartesian direction - (float, str): angle + direction - (float, 3 floats): angle + vector of rotation - Quaternion Or any sequence of the above. In this, latter case, they will be combined into a single Quaternion. 4. General clean-ups in the spin-align method. 5. Added checks to ensure Hermitian matrix after rotation. The code is relatively simple, and allows for much improved handling. Signed-off-by: Nick Papior <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Nick Papior <[email protected]>
Signed-off-by: Nick Papior <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #930 +/- ##
==========================================
+ Coverage 86.86% 86.94% +0.07%
==========================================
Files 412 412
Lines 54309 54313 +4
==========================================
+ Hits 47176 47220 +44
+ Misses 7133 7093 -40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #924.
The problem was that the rotation should be performed using the Lie group SU(2) rotation matrix.
This merge does a lot of things:
extends Quaternion to return norm2, rotation_matrix rotation_matrix_su2, rotation_vector.
A bug in reduction calls for sparse matrices that are complex. It had used the wrong data-type.
Generalized rotation arguments to allow more, and simpler rotations. Now the rotations can be any of:
Or any sequence of the above. In this, latter case,
they will be combined into a single Quaternion.
General clean-ups in the spin-align method.
Added checks to ensure Hermitian matrix after rotation.
The code is relatively simple, and allows for much improved handling.
docs/changes/<pr-num>.<type>.rst