Use testcontainers for test, instead of local zerotier-one #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laduke
force-pushed
the
laduke/testcontainers
branch
2 times, most recently
from
ba733e8
to
ca59639
Compare
rcoder
reviewed
Apr 11, 2024
laduke
force-pushed
the
laduke/testcontainers
branch
from
ca59639
to
615c0f6
Compare
Before, we assume that the host/dev env had a zerotier-one service running. Now we can start a container and use the zerotier-one in there, and then throw it away.
laduke
force-pushed
the
laduke/testcontainers
branch
from
615c0f6
to
1122c4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, we assumed that the host/dev-env had a zerotier-one service running.
Now we can start a container and use the zerotier-one in there, and then throw it away.
No messing up your local service. No having to switch its version around. Should work for anyone with a docker runtime.