Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove athens3 binary list #25

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

remove athens3 binary list #25

wants to merge 1 commit into from

Conversation

morde08
Copy link
Contributor

@morde08 morde08 commented Nov 7, 2024

Description

  • remove athens3 binary list as it is deprecated

Is this deployed somewhere outside of the CI/CD process already, and if so, where?

  • Developnet
  • Athens-Validators
  • Mainnet-Validators

How Has This Been Tested?

Checklist:

  • I have performed a self-review of my code
  • My changes generate no new warnings

Summary by CodeRabbit

  • Chores
    • Removed the binary_list.json file, which previously listed download links for various binary releases of the zetacored application.

@morde08 morde08 requested a review from a team as a code owner November 7, 2024 22:33
Copy link

coderabbitai bot commented Nov 7, 2024

📝 Walkthrough

Walkthrough

The pull request involves the deletion of the binary_list.json file located in the athens3/ directory. This file previously contained a JSON object that listed various binary releases for the zetacored application, detailing download URLs and binary locations for multiple versions. The removal suggests a shift in how binary releases are managed or represented within the project.

Changes

File Path Change Summary
athens3/binary_list.json Removed the JSON file that listed binary releases for zetacored.

Possibly related PRs

  • Add v19 binary to Testnet binary_list.json #18: This PR adds a new entry for version 19.0.0 to the binary_list.json, which is directly related to the structure and purpose of the deleted binary_list.json file in the main PR.
  • update binaries for mainnet and athens3 #21: This PR updates the binary_list.json by adding a new binary version (20.0.1) and modifying the existing structure, which connects to the changes made in the main PR regarding the removal of the entire file.
  • add v20.0.2 binary for mainnet #22: This PR introduces a new entry for version 20.0.2 in the mainnet/binary_list.json, which is relevant as it pertains to the same binary management context as the deleted binary_list.json in the main PR.

Suggested reviewers

  • gartnera

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between d0a78a8 and c730d9b.

📒 Files selected for processing (1)
  • athens3/binary_list.json (0 hunks)
💤 Files with no reviewable changes (1)
  • athens3/binary_list.json

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@julianrubino
Copy link
Member

is Mainnet being used somewhere?

Copy link
Member

@gartnera gartnera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'd still need this if you wanted to try and sync from zero right?

@morde08
Copy link
Contributor Author

morde08 commented Nov 7, 2024

is Mainnet being used somewhere?
@julianrubino I don't think so but I'm just staggering the deletes

@morde08
Copy link
Contributor Author

morde08 commented Nov 7, 2024

You'd still need this if you wanted to try and sync from zero right?

I don't think you NEED this list as if you were to fully sync from zero you could also just look at the list of releases on node repo. Not sure how much value having this separate file provides and it's overhead for us to keep it up to date.

@julianrubino
Copy link
Member

I don't think you NEED this list as if you were to fully sync from zero you could also just look at the list of releases on node repo. Not sure how much value having this separate file provides and it's overhead for us to keep it up to date.

You could watch proposals and then download the correct releases, but it's a bit painful to do that, it's easier if we could provide an upgrade path that can easily be automated to download all binaries and sync from genesis.

The bad thing is that we would need to maintain this

@gartnera
Copy link
Member

gartnera commented Nov 7, 2024

I think we need to keep the old pre v19 list but I don't think we need to update this anymore so long as you set DAEMON_ALLOW_DOWNLOAD_BINARIES=true. You need to preload up to v19 based on the json then autodownload will should take care of the rest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants