-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove athens3 binary list #25
base: main
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughThe pull request involves the deletion of the Changes
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
is Mainnet being used somewhere? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'd still need this if you wanted to try and sync from zero right?
|
I don't think you NEED this list as if you were to fully sync from zero you could also just look at the list of releases on node repo. Not sure how much value having this separate file provides and it's overhead for us to keep it up to date. |
You could watch proposals and then download the correct releases, but it's a bit painful to do that, it's easier if we could provide an upgrade path that can easily be automated to download all binaries and sync from genesis. The bad thing is that we would need to maintain this |
I think we need to keep the old pre v19 list but I don't think we need to update this anymore so long as you set |
Description
Is this deployed somewhere outside of the CI/CD process already, and if so, where?
How Has This Been Tested?
Checklist:
Summary by CodeRabbit
binary_list.json
file, which previously listed download links for various binary releases of thezetacored
application.