Skip to content

feat(gateway)!: implement foundational logic for gas fees #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 16, 2024
Merged

feat(gateway)!: implement foundational logic for gas fees #17

merged 10 commits into from
Oct 16, 2024

Conversation

swift1337
Copy link
Contributor

@swift1337 swift1337 commented Oct 14, 2024 •
edited
Loading

Changes

  • Make gas fees deterministic for all op
  • Estimate gas usage, add stats export to CSV
  • Add int calculate_gas_fee(int op) method_id getter for tx cost estimation
  • Improve TSS signature payload.
  • Update readme
  • Come up w/ a strategy for non-existent withdrawal addresses
  • Setup CI
  • Additional test cases
  • Add CLI wrapper with make tx
  • Restrict withdrawals to Gateway itself

Closes #2, #6, #9, #16

@swift1337 swift1337 changed the title feat(gateway)!: feat(gateway)!: gas fees Oct 14, 2024
@swift1337 swift1337 self-assigned this Oct 14, 2024
swift1337
swift1337 commented Oct 14, 2024
View reviewed changes
@swift1337 swift1337 force-pushed the feat/improve-tx-fees branch from 1edf7dc to 8befa6b Compare October 14, 2024 21:36
@swift1337 swift1337 marked this pull request as ready for review October 14, 2024 21:36
@swift1337 swift1337 changed the title feat(gateway)!: gas fees feat(gateway)!: gas fees groundwork Oct 14, 2024
@swift1337 swift1337 changed the title feat(gateway)!: gas fees groundwork feat(gateway)!: implement foundational logic for gas fee Oct 14, 2024
@swift1337 swift1337 changed the title feat(gateway)!: implement foundational logic for gas fee feat(gateway)!: implement foundational logic for gas fees Oct 14, 2024
lumtis
lumtis reviewed Oct 15, 2024
View reviewed changes
@swift1337 swift1337 force-pushed the feat/improve-tx-fees branch from efe8e27 to 7d13d4f Compare October 15, 2024 13:27
@swift1337 swift1337 force-pushed the feat/improve-tx-fees branch from 7d13d4f to 8c58d8e Compare October 15, 2024 13:31
@swift1337 swift1337 requested a review from lumtis October 15, 2024 14:25
@swift1337 swift1337 merged commit e3b0098 into main Oct 16, 2024
2 checks passed
@swift1337 swift1337 mentioned this pull request Oct 17, 2024
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lumtis lumtis lumtis approved these changes

@fbac fbac Awaiting requested review from fbac

@skosito skosito Awaiting requested review from skosito skosito is a code owner

Assignees

@swift1337 swift1337

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add CI
2 participants
@swift1337 @lumtis