fix(gateway): fix withdrawal edge-case #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-merge-queue bot
pushed a commit
to zeta-chain/node
that referenced
this pull request
Oct 30, 2024
* Apply changes from recent Gateway refactoring * Move GW logic to pkg/contracts/ton. Fix E2E tests * Implement watchRPCStatus() for TON * Implement watchGasPrice() for TON * Add Withdraw message w/ payload signature * Minor refactoring * Add TON signer * Add withdrawal parsing; Update Gateway with a fix of zeta-chain/protocol-contracts-ton#19 * Add signer tests * Add addOutboundTracker to *observer*; Add TSS cache for signatures * Update GW (zeta-chain/protocol-contracts-ton#20) * Add test cases for withdrawals in observeGateway() * Add observe outbound * Enforce additional validation on withdrawal parsing * Implement TON cctx scheduler * Implement TON VoteOutboundIfConfirmed * TON withdrawal E2E * Update changelog * gosec * Address PR comments [1] * Address PR comments [2] * Address PR comments [3] * Address PR comments [4] * Bump ton-docker image version * gosec * Address PR comments [5] * Rollback to prev. ton-docker * Address PR comments [6]
github-merge-queue bot
pushed a commit
to zeta-chain/node
that referenced
this pull request
Oct 30, 2024
* Apply changes from recent Gateway refactoring * Move GW logic to pkg/contracts/ton. Fix E2E tests * Implement watchRPCStatus() for TON * Implement watchGasPrice() for TON * Add Withdraw message w/ payload signature * Minor refactoring * Add TON signer * Add withdrawal parsing; Update Gateway with a fix of zeta-chain/protocol-contracts-ton#19 * Add signer tests * Add addOutboundTracker to *observer*; Add TSS cache for signatures * Update GW (zeta-chain/protocol-contracts-ton#20) * Add test cases for withdrawals in observeGateway() * Add observe outbound * Enforce additional validation on withdrawal parsing * Implement TON cctx scheduler * Implement TON VoteOutboundIfConfirmed * TON withdrawal E2E * Update changelog * gosec * Address PR comments [1] * Address PR comments [2] * Address PR comments [3] * Address PR comments [4] * Bump ton-docker image version * gosec * Address PR comments [5] * Rollback to prev. ton-docker * Address PR comments [6]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should not happen, but if so - the gateway could have been drained by gas fees and infinite retry when the signed withdrawal amount is larger than
total_lockedfunds