-
Notifications
You must be signed in to change notification settings - Fork 6
docs: readme #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: readme #50
Conversation
📝 WalkthroughWalkthroughThe pull request completely overhauls the content and structure of the Changes
Tip 🌐 Web search-backed reviews and chat
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
readme.md (1)
22-41
: Valuable OpenZeppelin Integration Guidelines with Minor Markdown Adjustments.
The "OpenZeppelin Integration 🏗️" section provides clear, actionable code snippets to help users integrate cross-chain functionality into existing OpenZeppelin upgradeable contracts.Note: The markdownlint tool highlights a minor issue in the subheadings:
- Line 27: The heading "### For Universal NFT:" has a trailing colon.
- Line 33: The heading "### For Universal Token:" has a trailing colon.
These should be updated to remove the colons for consistency with markdown style guidelines (MD026). For example:
-### For Universal NFT: +### For Universal NFT-### For Universal Token: +### For Universal TokenImplementing this change will ensure that the document adheres to best practices without impacting the clarity of the instructions.
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
27-27: Trailing punctuation in heading
Punctuation: ':'(MD026, no-trailing-punctuation)
33-33: Trailing punctuation in heading
Punctuation: ':'(MD026, no-trailing-punctuation)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
readme.md
(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
readme.md
27-27: Trailing punctuation in heading
Punctuation: ':'
(MD026, no-trailing-punctuation)
33-33: Trailing punctuation in heading
Punctuation: ':'
(MD026, no-trailing-punctuation)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: test (contracts/token)
- GitHub Check: test (contracts/nft)
- GitHub Check: slither (contracts/token, token.sarif)
- GitHub Check: slither (contracts/nft, nft.sarif)
🔇 Additional comments (5)
readme.md (5)
1-6
: Clear Rebranding and Introduction Update.
The title change to "ZetaChain Standard Contracts 🚀" and the introductory text effectively communicate the new focus on cross-chain capabilities for ERC-721 (NFT) and ERC-20 (Token) deployments. The updated language is engaging and sets the right tone for the rest of the document.
7-13
: Enhanced Navigation via Contents Section.
The newly added "Contents 📦" section is a great addition. It provides quick links to essential documentation for Universal NFT and Token, thereby improving overall navigability for the reader.
14-21
: Well-Structured Installation Instructions.
The "Installation ⚙️" section clearly presents the npm and yarn commands within a neatly formatted bash code block. This enhances user experience by offering straightforward, copy-paste instructions.
42-57
: Comprehensive ThirdWeb Deployment Section.
The "Using ThirdWeb 🌐" section provides clear guidance on deploying Universal NFTs and Tokens via ThirdWeb, complete with relevant links. This addition expands the document's utility for users exploring alternative deployment platforms.
58-61
: Effective Documentation References.
The concluding section that directs readers to further NFT and Token documentation is a strong finishing touch, ensuring users have access to more detailed technical resources as needed.
Summary by CodeRabbit