Do not leak compile options outside project#1030
Closed
vocasle wants to merge 1 commit intozeux:masterfrom
Closed
Conversation
Owner
I was under the impression that this is already scoped to targets defined in the folder (/subdirectories) of the current CMakeLists file? Iow it should not propagate to targets defined outside of meshoptimizer source. |
Author
|
My apologies. I was looking for the root cause of This is an excerpt from Sorry for the hustle. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change reduces the scope of compile options from other CMake targets and applies them only to targets defined in root CMakeLists.txt.
add_compile_options sets compile options to all CMake targets.
target_compile_options allows to narrow the scope to targets defined in root CMakeLists.txt.