Conversation
Both functions have had a consistent interface for a while with no future changes planned short of implementation improvements.
This allows using meshopt_simplifyPrune with other index types, similarly to all other simplify* functions.
When using C++, we now specify an inline overload that omits version argument. When version will default to 1 in a future update, this will make using specific level a little more obvious, without changes to API/ABI compatibility.
Mark encodeVertexBufferLevel, partitionClusters, spatialClusterPoints as likely to become stable in the next version: neither function has anticipated changes in the interface or behavior.
This includes accumulated source changes to various algorithms.
This name better reflects the nature of the algorithm and seems somewhat more intuitive; "split" was either too generic (all meshlet builders split the input sequence) or too imprecise (no triangle splitting is performed), and overlapped with split_weight in Flex builder unnecessarily.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates versions and sets of stable APIs, adds C++ wrappers for
simplifyPruneandencodeVertexBufferLevel, and renamesbuildMeshletsSplittobuildMeshletsSpatialas that seems like a better long-term name for the algorithm.Stabilized APIs:
meshopt_generateProvokingIndexBuffer,meshopt_spatialSortTrianglesAPIs that are still experimental:
Introduced in this release, likely will be stabilized with no changes
meshopt_analyzeCoveragemeshopt_generateVertexRemapCustommeshopt_buildMeshletsSpatial(modulo potential addition of extra tunables)meshopt_simplifyPrunemeshopt_spatialClusterPointsChanged in this release, likely will be stabilized with no further changes
meshopt_encodeVertexBufferLevelmeshopt_partitionClustersOthers
meshopt_buildMeshletsFlex- introduced in last release, no changes yet; not sure if the name is final?meshopt_computeSphereBounds- introduced in last release, likely will be stabilized with no changesmeshopt_simplifySloppy- significant outstanding implementation and potentially interface work may happen soon