Skip to content

Link Threads::Threads instead of pthread #906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2025
Merged

Conversation

toge
Copy link
Contributor

@toge toge commented Jun 30, 2025

There is another improvement I'd like to see in CMakeLists.txt.

Even on UNIX systems, some environments don't provide pthreads, so I would prefer using Threads::Threads instead of pthreads.
This allows linking with C++11+ Threads in a platform-independent manner, supporting a broader range of environments. (ex. Android NDK)

@zeux zeux changed the title Please link Threads::Threads instead of pthread Link Threads::Threads instead of pthread Jun 30, 2025
@zeux zeux merged commit 1c870b3 into zeux:master Jun 30, 2025
13 checks passed
@zeux
Copy link
Owner

zeux commented Jun 30, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants